114943 – the hint 'replace {} with do/end' should replace with multiple lines

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 114943 - the hint 'replace {} with do/end' should replace with multiple lines

Summary: the hint 'replace {} with do/end' should replace with multiple lines

Status:	RESOLVED FIXED

Alias:	None

Product:	ruby
Classification:	Unclassified
Component:	Editing (show other bugs)
Version:	6.x
Hardware:	All All

Importance:	P3 blocker (vote)
Assignee:	Torbjorn Norbye

URL:
Keywords:

Depends on:
Blocks:

Reported:	2007-09-06 20:58 UTC by jamespb
Modified:	2007-09-07 04:19 UTC (History)
CC List:	0 users

See Also:
Issue Type:	DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description jamespb 2007-09-06 20:58:54 UTC

When I want to replace { thingy } with do thingy end, I always want multiple lines:

do
  thingy
end

The hint just replaces { } with do and end on the same line; you very rarely see that style.

Comment 1 Torbjorn Norbye 2007-09-07 04:19:45 UTC

Fixed in #3730. Expanding (and collapsing) code relies on the AST and works for the cases I've checked, but let me know
if you see some unusual line breaking.

IDE:-------------------------------------------------
IDE: [9/6/07 8:15 PM] Committing started
cvs server: scheduling file `convertblocks4.rb.testHintFix4.fixed' for addition
cvs server: scheduling file `convertblocks4.rb' for addition
cvs server: scheduling file `convertblocks4.rb.testHint9.hints' for addition
cvs server: scheduling file `convertblocks.rb.testFix4.fixed' for addition
cvs server: scheduling file `convertblocks4.rb.testHint11.hints' for addition
cvs server: scheduling file `convertblocks4.rb.testHintFix1.fixed' for addition
cvs server: scheduling file `convertblocks4.rb.testHintFix8.fixed' for addition
cvs server: scheduling file `convertblocks4.rb.testHintFix6.fixed' for addition
cvs server: scheduling file `convertblocks4.rb.testHintFix7.fixed' for addition
cvs server: scheduling file `convertblocks4.rb.testHint7.hints' for addition
cvs server: scheduling file `convertblocks4.rb.testHintFix2.fixed' for addition
cvs server: scheduling file `convertblocks4.rb.testHintFix3.fixed' for addition
cvs server: scheduling file `convertblocks4.rb.testHintFix10.fixed' for addition
cvs server: scheduling file `convertblocks4.rb.testHint8.hints' for addition
cvs server: scheduling file `convertblocks4.rb.testHintFix9.fixed' for addition
cvs server: scheduling file `convertblocks4.rb.testHintFix5.fixed' for addition
cvs server: scheduling file `convertblocks4.rb.testHint10.hints' for addition
cvs server: use 'cvs commit' to add these files permanently
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix5.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHintFix5.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix5.fixed,v  <-- 
convertblocks4.rb.testHintFix5.fixed
initial revision: 1.1
done
Checking in test/unit/data/testfiles/convertblocks3.rb.testOneLineHint3.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks3.rb.testOneLineHint3.hints,v  <-- 
convertblocks3.rb.testOneLineHint3.hints
new revision: 1.2; previous revision: 1.1
done
Checking in test/unit/data/testfiles/convertblocks3.rb.testOneLineHint4.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks3.rb.testOneLineHint4.hints,v  <-- 
convertblocks3.rb.testOneLineHint4.hints
new revision: 1.2; previous revision: 1.1
done
Checking in test/unit/data/testfiles/convertblocks.rb.testHint2.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks.rb.testHint2.hints,v  <-- 
convertblocks.rb.testHint2.hints
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix3.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHintFix3.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix3.fixed,v  <-- 
convertblocks4.rb.testHintFix3.fixed
initial revision: 1.1
done
Checking in test/unit/data/testfiles/convertblocks3.rb.testOneLineHint5.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks3.rb.testOneLineHint5.hints,v  <-- 
convertblocks3.rb.testOneLineHint5.hints
new revision: 1.3; previous revision: 1.2
done
Checking in test/unit/data/testfiles/convertblocks3.rb.testOneLineHintFix3.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks3.rb.testOneLineHintFix3.fixed,v  <-- 
convertblocks3.rb.testOneLineHintFix3.fixed
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix8.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHintFix8.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix8.fixed,v  <-- 
convertblocks4.rb.testHintFix8.fixed
initial revision: 1.1
IDE: [9/6/07 8:15 PM] Diffing finished
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix1.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHintFix1.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix1.fixed,v  <-- 
convertblocks4.rb.testHintFix1.fixed
initial revision: 1.1
done
Checking in test/unit/data/testfiles/convertblocks3.rb.testOneLineHintFix4.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks3.rb.testOneLineHintFix4.fixed,v  <-- 
convertblocks3.rb.testOneLineHintFix4.fixed
new revision: 1.3; previous revision: 1.2
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHint11.hints,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHint11.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHint11.hints,v  <-- 
convertblocks4.rb.testHint11.hints
initial revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHint9.hints,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHint9.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHint9.hints,v  <-- 
convertblocks4.rb.testHint9.hints
initial revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix4.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHintFix4.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix4.fixed,v  <-- 
convertblocks4.rb.testHintFix4.fixed
initial revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHint10.hints,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHint10.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHint10.hints,v  <-- 
convertblocks4.rb.testHint10.hints
initial revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix9.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHintFix9.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix9.fixed,v  <-- 
convertblocks4.rb.testHintFix9.fixed
initial revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHint8.hints,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHint8.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHint8.hints,v  <-- 
convertblocks4.rb.testHint8.hints
initial revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix10.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHintFix10.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix10.fixed,v  <-- 
convertblocks4.rb.testHintFix10.fixed
initial revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix2.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHintFix2.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix2.fixed,v  <-- 
convertblocks4.rb.testHintFix2.fixed
initial revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHint7.hints,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHint7.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHint7.hints,v  <-- 
convertblocks4.rb.testHint7.hints
initial revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix7.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHintFix7.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix7.fixed,v  <-- 
convertblocks4.rb.testHintFix7.fixed
initial revision: 1.1
done
Checking in test/unit/data/testfiles/convertblocks3.rb.testOneLineHint2.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks3.rb.testOneLineHint2.hints,v  <-- 
convertblocks3.rb.testOneLineHint2.hints
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix6.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb.testHintFix6.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb.testHintFix6.fixed,v  <-- 
convertblocks4.rb.testHintFix6.fixed
initial revision: 1.1
done
Checking in test/unit/data/testfiles/convertblocks2.rb.testHint6.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks2.rb.testHint6.hints,v  <-- 
convertblocks2.rb.testHint6.hints
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks.rb.testFix4.fixed,v
done
Checking in test/unit/data/testfiles/convertblocks.rb.testFix4.fixed;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks.rb.testFix4.fixed,v  <--  convertblocks.rb.testFix4.fixed
initial revision: 1.1
done
Checking in test/unit/data/testfiles/convertblocks.rb.testHint3.hints;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks.rb.testHint3.hints,v  <-- 
convertblocks.rb.testHint3.hints
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb,v
done
Checking in test/unit/data/testfiles/convertblocks4.rb;
/cvs/ruby/hints/extrahints/test/unit/data/testfiles/convertblocks4.rb,v  <--  convertblocks4.rb
initial revision: 1.1
done
Checking in src/org/netbeans/modules/ruby/extrahints/ConvertBlockType.java;
/cvs/ruby/hints/extrahints/src/org/netbeans/modules/ruby/extrahints/ConvertBlockType.java,v  <--  ConvertBlockType.java
new revision: 1.8; previous revision: 1.7
done
Checking in src/org/netbeans/modules/ruby/extrahints/Bundle.properties;
/cvs/ruby/hints/extrahints/src/org/netbeans/modules/ruby/extrahints/Bundle.properties,v  <--  Bundle.properties
new revision: 1.9; previous revision: 1.8
done
Checking in test/unit/src/org/netbeans/modules/ruby/extrahints/ConvertBlockTypeTest.java;
/cvs/ruby/hints/extrahints/test/unit/src/org/netbeans/modules/ruby/extrahints/ConvertBlockTypeTest.java,v  <-- 
ConvertBlockTypeTest.java
new revision: 1.5; previous revision: 1.4
done
IDE: [9/6/07 8:15 PM] Committing finished