This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 122141 - Diff is not refreshed after committing changes.
Summary: Diff is not refreshed after committing changes.
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-16 12:58 UTC by Peter Pis
Modified: 2008-01-03 09:34 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
proposed patch (2.93 KB, patch)
2007-11-16 14:01 UTC, Padraig Obriain
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Pis 2007-11-16 12:58:46 UTC
Product Version: NetBeans IDE 6.0 RC1 (Build 200711160000)
Java: 1.6.0_03; Java HotSpot(TM) Client VM 1.6.0_03-b05
System: Windows XP version 5.1 running on x86; Cp1252; en_GB (nb)
Userdir: D:\ide\60daily\user

Steps:
1. Create new project.
2. Select project root and invoke "Versioning | Initialize Mercurial repository" action.
3. Invoke "Mercurial | Show Status" action on project root.
4. Push Diff button from the Status - Mercurial view.
5. From the Diff panel push "Commit" button. Commit all changes. 

Status view is refreshed, but diff panel table that lists modified files is not.
Comment 1 Peter Pis 2007-11-16 13:00:33 UTC
It's a general problem, I've found another scenario. If the file is modified and diff panel is opened diff table is not
refreshed automatically.
Comment 2 Padraig Obriain 2007-11-16 14:01:10 UTC
Created attachment 53125 [details]
proposed patch
Comment 3 Padraig Obriain 2007-11-16 14:03:44 UTC
The diff code for mercurial is essentially a copy of the code for Subversion.

For subversion when a file changes a VersioningEvent is fired.
For mercurial when a file changes a PropertyChangeEvent is fired.

The change is to listen for the correct event.
Comment 4 Padraig Obriain 2007-11-19 11:58:52 UTC
Patch committed to CVS HEAD.

IDE:-------------------------------------------------
IDE: [11/19/07 11:57 AM] Committing "MultiDiffPanel.java" started
Checking in MultiDiffPanel.java;
/shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/diff/MultiDiffPanel.java,v 
<--  MultiDiffPanel.java
new revision: 1.2; previous revision: 1.1
done
IDE: [11/19/07 11:58 AM] Committing "MultiDiffPanel.java" finished
Comment 5 Peter Pis 2007-12-07 09:39:01 UTC
Verified.