This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 124115 - lot of duplicated code in JaxWsCodeGenerator.java
Summary: lot of duplicated code in JaxWsCodeGenerator.java
Status: VERIFIED FIXED
Alias: None
Product: webservices
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Milan Kuchtiak
URL:
Keywords:
Depends on:
Blocks: 122497
  Show dependency tree
 
Reported: 2007-12-17 13:04 UTC by Lukas Jungmann
Modified: 2008-02-17 05:07 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
cpd output (9.92 KB, text/plain)
2007-12-17 13:04 UTC, Lukas Jungmann 		Details
proposed patch (43.56 KB, text/plain)
2007-12-17 22:20 UTC, Lukas Jungmann 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lukas Jungmann 2007-12-17 13:04:06 UTC 
see attachment
Comment 1 Lukas Jungmann 2007-12-17 13:04:44 UTC 
Created attachment 54317 [details]
cpd output
Comment 2 Lukas Jungmann 2007-12-17 22:20:22 UTC 
Created attachment 54342 [details]
proposed patch
Comment 3 Lukas Jungmann 2007-12-17 22:29:23 UTC 
insertMethodCall(...) and insertMethod(...) are almost the same (I've found there only one major difference - the first
method call also addProjectReference(...) method). Attached patch simplifies this, but should be carefully reviewed to
avoid possible regression(s), which could be caused by some already fixed issue in one method, but not in the other, if
you want to apply it.

Anyway the patch removes ~230 lines of mostly duplicated/cut&pasted code.
Comment 5 Lukas Jungmann 2008-02-17 05:07:58 UTC 
v.