This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 125424 - ResourceUtils contains many bugs
Summary: ResourceUtils contains many bugs
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 9 (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Nitya Doraisamy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-16 19:38 UTC by Petr Hejl
Modified: 2009-04-15 01:59 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Hejl 2008-01-16 19:38:02 UTC 
Class ResourceUtils in module "Sun Java System Application Server Common APIs" contains many bugs reported by findbugs.
One bug that is really common is catching Exception - this will catch any exception - do not ever do this. Catch just
checked exceptions that can be thrown. In addition catch block in this class usually does nothing - please at least log it.

Other thing reported by findbugs is possible null pointer dereference.

Please fix it.
Comment 1 Nitya Doraisamy 2008-02-29 06:08:14 UTC 
Will evaluate and resolve/update for Findbugs issues
Comment 2 Vince Kraemer 2008-04-26 04:55:44 UTC 
This got missed
Comment 3 Vince Kraemer 2008-04-26 04:56:14 UTC 
need to re-evaluate.
Comment 4 pslechta 2008-06-19 11:40:04 UTC 
Fixed. Improved exception handling. Removed dependency on deprecated ErrorManager.

http://hg.netbeans.org/main/rev/533eb9ef1407

The code may require additional refactoring (exception flow is too complicated in some cases)...
Petre, please reopen this issue if changes are not sufficient (or file another more specific bug).
Thanks!
Comment 5 Vince Kraemer 2008-11-15 00:32:14 UTC 
there is still a large number of bugs found by findbugs...
Comment 6 Vince Kraemer 2008-11-15 00:33:36 UTC 
nitya: please evaluate and resolve some of the issues in this class.
Comment 7 Nitya Doraisamy 2008-12-12 19:54:42 UTC 
Making a pass of fixing FindBugs issues in the ResourceUtils class as part of changes for Milestone1.
Comment 8 Nitya Doraisamy 2008-12-12 21:16:23 UTC 
Assigned wrong milestone, first pass will be done by M1
Comment 9 Nitya Doraisamy 2009-04-15 01:59:58 UTC 
Couple of scrubs completed. In much cleaner shape