This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 129193 - provide source editor for customization files
Summary: provide source editor for customization files
Status: NEW
Alias: None
Product: webservices
Classification: Unclassified
Component: Customization (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Roderico Cruz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-04 22:15 UTC by Lukas Jungmann
Modified: 2008-03-05 15:36 UTC (History)
2 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lukas Jungmann 2008-03-04 22:15:54 UTC
currently there's no way for the user to easily find and edit JAX-WS/JAXB customization files for from WSDL scenarios.
It would be great to provide editing ability directly in edit ws attributes dialog, the UI could look like this (wanna
be UI spec ;-) ):


Components of this dialog are mostly as of now with following changes only in WSDL Customization tab:

- added a toolbar to the tab which allows user to switch between Design (current) view and Source view

- Binding File - non-editable(?) combobox where particular binding file can be selected for editing, always contains
some default binding file which is empty and only in memory until user changes something in the ui

- Add, Remove buttons - provides user control over the used binding files

- [x] Keep original ... - allows user to save current ws impl class if it needs to be recreated, should be checked by
default (intended to replace current info dialog popping up after closing the wizard, probably makes sense also for
wsimport options tab)


Design view:

+--------------------------------------------------------------------------------+
|                             MyWebService                                       |
|                                                                                |
| Configure security...                                                          |
|                                                                                |
| ___  __________________  ________________                                      |
|/Qos\/WSDL Customization\/WsImport Options\                                     |
+----/                    \------------------------------------------------------+
|[//Design//][Source] Binding File: |_DefaultBinding.xml__|_v_| [Add...] [Remove]|
|                                                                                |
|         <current UI for WSDL Customization editor excluding                    |
|          external binding files section>                                       |
...
+--------------------------------------------------------------------------------+
|[x] Keep original Web Service implementation class (will be renamed to *.orig)  |
+--------------------------------------------------------------------------------+
|                                                      [ OK ][ Cancel ] [ Help ] |
+--------------------------------------------------------------------------------+


Source view:

+--------------------------------------------------------------------------------+
|                             MyWebService                                       |
|                                                                                |
| Configure security...                                                          |
|                                                                                |
| ___  __________________  ________________                                      |
|/Qos\/WSDL Customization\/WsImport Options\                                     |
+----/                    \------------------------------------------------------+
|[Design][//Source//] Binding File: |_DefaultBinding.xml__|_v_| [Add...] [Remove]|
|                                                                                |
|      <current NetBeans XML editor providing standard                           |
|       editing features (CC, validation,...)                                    |
|       should also use standard XML editor toolbar>                             |
...
+--------------------------------------------------------------------------------+
|[x] Keep original Web Service implementation class (will be renamed to *.orig)  |
+--------------------------------------------------------------------------------+
|                                                      [ OK ][ Cancel ] [ Help ] |
+--------------------------------------------------------------------------------+
Comment 1 Milan Kuchtiak 2008-03-05 15:01:01 UTC
Thanks Lukas you filed this.
Isn't this intended to be an enhancement ?

Few Questions ?
Is this only expected for WS from WSDL and WS Client scenarios ?
What do you mean with source ? Is that wsdl file ?

What about wsit customization (WS Security, MTOM,...) ? should we also provide editing capability for those config files ?

Comment 2 Lukas Jungmann 2008-03-05 15:27:47 UTC
> Isn't this intended to be an enhancement ?

 yes, this is definitely an enhancement :)


> Is this only expected for WS from WSDL and WS Client scenarios ?

  yes, in from java scenarios there are no binding files, so this would not make sense, IMHO


> What do you mean with source ? Is that wsdl file ?

  no, source editor would be only for a binding file for some wsdl file (WSDL file itself can be opened and modified by
doubleclick on the ws client node now and I personally don't see any use-case for allowing editing WSDL in cust. editor)


> What about wsit customization (WS Security, MTOM,...) ? should we also provide editing capability for those config files ?

  I think we should not do that in this case, but I don't have strong opinion on this (haven't been investigating that
yet). Martin, would it be useful for you or your users?



Another option for editing binding files would be only adding an "Edit" action (closes the Edit WS attrs dialog and
opens selected binding file in standard editor in the IDE), probably simpler solution:

+--------------------------------------------------------------------------------+
|                             MyWebService                                       |
|                                                                                |
| Configure security...                                                          |
|                                                                                |
| ___  __________________  ________________                                      |
|/Qos\/WSDL Customization\/WsImport Options\                                     |
+----/                    \------------------------------------------------------+
|Binding File:   |___DefaultBinding.xml___________|_v_| [Add...] [Remove] [Edit] |
|                                                                                |
|         <current UI for WSDL Customization editor excluding                    |
|          external binding files section>                                       |
...
+--------------------------------------------------------------------------------+
|[x] Keep original Web Service implementation class (will be renamed to *.orig)  |
+--------------------------------------------------------------------------------+
|                                                      [ OK ][ Cancel ] [ Help ] |
+--------------------------------------------------------------------------------+
Comment 3 Martin Grebac 2008-03-05 15:36:34 UTC
I'd more suggest to move ALL these to WS source editor as separate tabs (Qos, customization, ...). Having source view in
a separate dialog doesn't make much sense to me. Or have all the dialog content as one tab in the WS editor, that's also
possible. 
 As for WSIT specific things, we are really trying to hide the config files from users, but there are cases where they
need to care about those anyway.