This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 13036 - Add declarative way of adding node factories
Summary: Add declarative way of adding node factories
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 3.x
Hardware: Sun Solaris
: P1 blocker (vote)
Assignee: Svata Dedic
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2001-06-20 17:50 UTC by Petr Nejedly
Modified: 2001-08-27 14:41 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Exception Reporter:


Attachments
Proposed patch for the javadoc module (2.66 KB, patch)
2001-08-23 18:38 UTC, Svata Dedic
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Nejedly 2001-06-20 17:50:07 UTC
There is a calling API for adding node factories to
ClassDataObject/JavaDataObject
that is used e.g. by Beans module and JavaDoc module.
If would be better to use declarative way of specifying node factories,
e.g. using module layers and Lookup.
It would save Beans module some instalation work (its ModuleInstall
can then go away totaly) and spase some classes at startup
(7 for clazz module, maybe some(up to 20 when some other criterion
will be met) for java module, 6 for beans module)
Comment 1 Petr Nejedly 2001-06-20 18:37:53 UTC
BTW: When connected with the change I've just made to not resolve FormDataObject
from i18n.form.I18nFormCrossModule, it can really spare ~21 classes of Java
module at startup
Comment 2 Svata Dedic 2001-07-09 15:51:11 UTC
Reassinging to netbeans.org mailing address.
Comment 3 Petr Nejedly 2001-08-13 16:49:13 UTC
Also can cause early loading of SourceOptions, increasing priority.
Comment 4 Svata Dedic 2001-08-23 17:54:20 UTC
Adding people, who I know to use node factories, on the CC: list
Comment 5 Svata Dedic 2001-08-23 18:38:05 UTC
Created attachment 2291 [details]
Proposed patch for the javadoc module
Comment 6 Svata Dedic 2001-08-23 18:39:59 UTC
Fixed in the dev trunk. Factory chains are lazily initialized upon
the first java/clazz node creation. Instances of factories are taken
from the module layers. Note, that layer-based factories always get
precedence over manually added ones.
Patch for javadoc module is provided.
Clazz module listens on "NodeFactories/clazz" rather than
NodeFactories/java to allow attaching factory specifically to one of
the modules.

Comment 7 Petr Nejedly 2001-08-27 14:41:05 UTC
Verified.