This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 132734 - Patch to load .jwt files in mobility projects
Summary: Patch to load .jwt files in mobility projects
Status: RESOLVED FIXED
Alias: None
Product: javame
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Petr Suchomel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-14 12:10 UTC by vprise
Modified: 2008-04-16 12:17 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vprise 2008-04-14 12:10:15 UTC 
It's in mobility/editor/src/org/netbeans/modules/mobility/editor/pub/J2MEDataLoader.java

This loader takes a java file if it is in mobility project, ignores otherwise, and it also checks if it has no .form
file (i.e. it explicitly knows it should ignore java files of Swing GUI forms). That's why our forms work well and yours
not - your data loader is registered later than the mobility one. I think you could try in your loader registration in
manifest.mf to change "Install-Before" to org.netbeans.modules.mobility.editor.pub.J2MEDataLoader

Probably not quite correct - not sure how it will behave when the mobility module is not available in the IDE
installation, so maybe J2MEDataLoader.java could be hacked the same way as for form files - to also pay attention to jwt
files...

  - Tomas
Comment 1 Lukas Hasik 2008-04-14 13:25:45 UTC 
I have no idea what is this issue talking about.
Why is it assigned to mobility?
Why is it PATCH without any patched files?
Why is it P1?

I'm marking as INCOMPLETE. Please, explain what is going on. Why we should care about any jwt files, etc. Provide patch
if you really mean it as patch. 

thank you
Comment 2 vprise 2008-04-14 13:36:28 UTC 
This issue was submitted by someone else with my user name. It should be assigned to Petr Suchomel.
Comment 3 Petr Suchomel 2008-04-15 16:47:00 UTC 
Fix is in J2MEDataLoader, added condition in line 101 !fo.existsExt("form") && !fo.existsExt("jwt")
CS 3c01d63e0618
Comment 4 Petr Suchomel 2008-04-15 16:54:34 UTC 
Sorry different CS 36320fbb2df8
Comment 5 Lukas Hasik 2008-04-15 18:56:45 UTC 
unable to verify in build however the condition will return null when there is *.jwt file. It won't change the behavior.
Fixes commited till midnight will appear in RC2. 

If you find the fix necessary for ES then go ahead and fix it (on your own responsibility). 
I'll be able to verify tomorrow.
Comment 6 vprise 2008-04-15 19:18:16 UTC 
When will a build be promoted so I can verify this?
Will it be in todays nightly?

Thanks.
Comment 7 Petr Suchomel 2008-04-15 21:25:24 UTC 
It is in trunk so it should be already available at http://deadlock.netbeans.org/hudson/job/trunk/, but seems to me
hudson has not registered it yet. Very unlikely to make it into 6.1, I am not able to get through mercurial issues
Comment 8 Jesse Glick 2008-04-15 22:46:32 UTC 
Transplanted to r61 as #d1a2f2003c26 on Petr's behalf.
Comment 9 vprise 2008-04-16 04:40:29 UTC 
I'm looking over http://deadlock.netbeans.org/hudson/job/trunk/changes and can't seem to find that particular fix, did
it land? Which build should I download to confirm?

Thanks.
Comment 10 Lukas Hasik 2008-04-16 08:22:56 UTC 
try it with latest build available at deadlock.nb.org/trunk. I cannot find the build where the fix was integrated
however it should be in the builds already. Please, let us know your results asap.

I'll try if the build works as expected (means no regressions) but I cannot check that the fix works for you.
Comment 11 vprise 2008-04-16 12:17:01 UTC 
I downloaded netbeans-hudson-trunk-1622.zip which fixed the problem! Thanks.
Hopefully it will be part of the RC.

Thanks.