This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 132918 - v3 doesn't appear in add dialog
Summary: v3 doesn't appear in add dialog
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Vince Kraemer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-15 19:55 UTC by Vince Kraemer
Modified: 2008-06-19 21:04 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
fix (8.38 KB, text/plain)
2008-06-19 10:11 UTC, Petr Hejl 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vince Kraemer 2008-04-15 19:55:31 UTC 
This may well be an issue in web project...

Here is the problem...

I pull recent release61 and main/contrib

I build the IDE from 6.1

I build the v3 plugins from main/contrib

I start the IDE

I go to File->New Project...

I select Web/web Application

I fill in the name and location data. Press Next

I get to the Server and settings page.  The combo box is blank (since I have not registered a server yet)

I press the "Add..." button

There is no GlassFish V3 "choice" in this server...

If I go to the Services tab to register/add the instance... the V3 server is a choice there.
Comment 1 _ pcw 2008-04-15 20:41:46 UTC 
Hi Vince, could you please check and see if this is this a duplicate of (or caused by the same bug as) issue 132879 and
close it as a duplicate of that if it is.
Comment 2 Vince Kraemer 2008-04-15 21:21:37 UTC 
it doesn't look like it is, since I have pulled the fix for issue 132879, verified that it was resolved and am still
stymied by the situation described in this issue.
Comment 3 Vince Kraemer 2008-06-18 21:29:00 UTC 
this is a bug in common server area....

the j2eeserver module exposes a way to open the add server dialog... which web project uses.

the common server module does not appear to expose the add server dialog, which means modules like web project have to
open the wrong dialog (the j2eeserver dialog doesn't deal with "common" servers).

it looks like this needs to be resolved by the owner of org.netbeans.modules.j2ee.common.project.ui.ProjectServerPanel
and the server module...
Comment 4 Petr Hejl 2008-06-19 10:08:53 UTC 
No it is not bug in common server. Web project does not call any code from common server.

There was a bug in the fact that server was displayed twice in server view add wizard. This was fixed by
OptionalDeploymentManagerFactory.isCommonUIRequired(), but gfv3 plugin does not use it. Perhaps it was "fixed" by
removing J2ee specific InstatiatingIterator.

Nevermind, attaching proper fix.
Comment 5 Petr Hejl 2008-06-19 10:11:08 UTC 
Created attachment 63064 [details]
fix
Comment 6 Vince Kraemer 2008-06-19 21:04:06 UTC 
applied and committed patch

http://hg.netbeans.org/main/rev/fe8d073263f5