This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 138884 - No error message on typing wrong path for installation location
Summary: No error message on typing wrong path for installation location
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 6.x
Hardware: Sun Windows XP
: P3 blocker (vote)
Assignee: _ pcw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-03 07:42 UTC by dpkumar
Modified: 2008-09-06 17:35 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dpkumar 2008-07-03 07:42:27 UTC
NetBeans Build:NetBeans IDE Build 200806300002
JDK Build:jdk1.6.0_06

Steps to reproduce:
1.Install NetBeans IDE.
2.In the GlassFish V3 download wizard,enter wrong path for GlassFish V3 platform location.In this case enter
install_dir::GlassFish V3_TP2.

Try even with these values:
-install_dir:/*/*GlassFish_V3_TP2
-install_dir:****GlassFish_V3_TP2
-install_dir:>GlassFish_V3_TP2
-install_dir:<GlassFish_V3_TP2
-install_dir:<?????????GlassFish_V3_TP2

Issue:
-Observe no error message in the wizard.
-If you start downloading GlassFish V3,after few seconds you can see the error message in the bottom of the wizard saying
"RunTime Exception:Failed to create folder:glassfish.Terminating archive installation". But still wizard says that
"GlassFish_V3_TP2 does not exist but GlassFish V3 can be downloaded and installed there".
Comment 1 _ pcw 2008-09-06 01:34:39 UTC
Option #1: Convert the mentioned RuntimeException into a special exception type and have the download flag the install
folder as unusable.  But this would be problematic, as minor changes to the folder name that didn't fix the problem
would allow a subsequent download that would still fail.

Option #2: Attempt to create install root folder immediately after the user hits <Finish> and reboot the wizard with an
error message if it fails.

Option #3: Attempt to validate the path in place and provide an error, only letting the user continue when it's acceptable.

The <New Java Project> uses a combination of #2 and #3.  They implement #3 by calling getCanonicalFile() on the absolute
path and seeing if it is successful.  It turns out this works except for the following illegal characters on
Windows/NTFS - < , >, and ".  They fall back on #2 to pick those up (and you get a different error message).

I opted for to fix this using method #3 by enhancing the method Java Project uses to also flag those 3 additional
illegal character when running on Windows.

I also cleaned up the messages a bit so that the full normalized path that is either to be used or is illegal is
displayed in the message (except wrt/ illegal characters - then we just show what was typed).  This makes it easier to
notice a relative path has been entered and what exactly that relative path is going to resolve to.
Comment 3 Quality Engineering 2008-09-06 17:35:52 UTC
Integrated into 'main-golden', will be available in build *200809061401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/42a4dec37e1b
User: pcw@netbeans.org
Log: #138884 Undesirable or illegal characters entered by user for glassfish install folder caused trouble for downloader.