This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 139243 - Delete Record(s) button enabled
Summary: Delete Record(s) button enabled
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Show Data (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Shansi 11
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-08 12:54 UTC by Andrei Badea
Modified: 2008-07-18 16:29 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Badea 2008-07-08 12:54:52 UTC
Just after executing a statement, or after moving to the next/previous page, the Delete Record(s) button is enabled, but
pressing it doesn't seem to do anything.
Comment 1 _ ahimanikya 2008-07-08 13:29:41 UTC
Please see the status bar message. Initially we had a popup but someone was complaining about it. We can set the first
row selected when you refresh the page.
Comment 2 Andrei Badea 2008-07-08 13:50:29 UTC
Please just disable the button. Then you won't need to care about the status bar or popup message.
Comment 3 _ ahimanikya 2008-07-08 16:05:41 UTC
I don't see what is the problem in the current approch, anyway this does not look like very important to me, will make
it as future.
Comment 4 Andrei Badea 2008-07-08 16:19:40 UTC
Well, if you don't see a problem with the current approach, it is quite unlikely that you will ever fix it.

The problem is that an enabled action (button, menu item, etc.) that doesn't do anything is considered bad UI. It makes
NetBeans looks unpolished. An user that is attentive to details will think "so why isn't the action disabled, if it
doesn't do anything?". Consider -- a lot of actions in the NetBeans main menu are disabled when they don't make sense.
Even in dataview, the page navigation buttons are displayed when there is only one page. So why do you insist on a
different behavior for this button?

Is fixing this a big problem, or does it require significat implementation effort?
Comment 5 _ ahimanikya 2008-07-08 19:48:30 UTC
Correct it require good amount of effort. if you can figure out how to fix this, send me a patch. I will be happy to
apply it. For now I will defer this.
Comment 6 _ ahimanikya 2008-07-08 21:55:03 UTC
I think you are correct I will never fix this. The solution that we have is good enough and this causes no side effect
or damage. So closing it.
Comment 7 Roman Mostyka 2008-07-09 09:24:22 UTC
Ahi, I don't agree. This issue doesn't damage anything except impression of NetBeans.
You and your team have fixed similar issue for SQL script for UPDATE. Here is the same situation. I understand that here
can be not enough resources, but this is not the reason for closing this issue, since it is still here.
So please, don't close this issue until it will be fixed.
If there is not enough resources, then this is the reason for discussion when it will be fixed and by who. Let's discuss
it on next meeting.
Comment 8 _ ahimanikya 2008-07-09 09:58:55 UTC
OK! I will see if I can find a way to fix this.
Comment 9 Shansi 11 2008-07-18 10:38:24 UTC
http://hg.netbeans.org/main/rev/193296a6f323
Comment 10 Roman Mostyka 2008-07-18 16:29:21 UTC
Verified with build 080718.