This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 139949 - [65cat] SQL History UI must have a maximum size
Summary: [65cat] SQL History UI must have a maximum size
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: PC Linux
: P3 blocker with 1 vote (vote)
Assignee: John Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-14 21:38 UTC by Michel Graciano
Modified: 2008-07-29 19:47 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
SQL History UI (12.23 KB, image/png)
2008-07-14 21:46 UTC, Michel Graciano
Details
More issues... (18.43 KB, image/png)
2008-07-24 15:19 UTC, Michel Graciano
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michel Graciano 2008-07-14 21:38:11 UTC
[ BUILD # : 200807040101 ]
[ JDK VERSION : 1.6.0_04 ]

Since I have connection with really huge name, when I open the SQL
History, the UI don't looks good. See the attachment for details.
It must have a maximum size on combo box.
Comment 1 Michel Graciano 2008-07-14 21:46:22 UTC
Created attachment 64475 [details]
SQL History UI
Comment 2 John Baker 2008-07-21 23:30:43 UTC
Should be fixed now.  Thank you for reporting.
91127:80cdaaf26075
Comment 3 Roman Mostyka 2008-07-22 16:02:03 UTC
Verified with build 080722.
Comment 4 Michel Graciano 2008-07-22 16:14:40 UTC
Thank you guys.
I updated the TM for 6.5 M2 which I hope is the correct. Fix it if necessary.

Regards.
Comment 5 Roman Mostyka 2008-07-22 16:35:46 UTC
hmichel, have you verifued this issue? Please do it with latest build, because I'm not able to reproduce it, but
probably you still have it.
Thanks.
Comment 6 Michel Graciano 2008-07-22 18:55:02 UTC
The build 200807221016 doesn't have the fix... I will try to test for next build.
Comment 7 John Baker 2008-07-22 18:58:40 UTC
I tested the fix using a very long JDBC URL ,
but just to be sure could you provide an example of your URL, thanks
Comment 8 Michel Graciano 2008-07-22 19:06:49 UTC
jdbc:oracle:thin:@(DESCRIPTION=                                 (ADDRESS_LIST=                                 (ADDRESS=
                                (PROTOCOL=TCP)                                 (HOST=XX.X.X.XXX)                       
         (PORT=XXXXX)))                                 (CONNECT_DATA=                                
(SERVICE_NAME=XXXXXX)                                 (SERVER=DEDICATED)))
Comment 9 John Baker 2008-07-22 19:44:37 UTC
hmichel, your URL contains CRLF or all options are on one line ?
Comment 10 Michel Graciano 2008-07-22 19:49:27 UTC
Just one line. I just replaced the connections details by 'X'.
Comment 11 Michel Graciano 2008-07-22 19:52:57 UTC
Just to clarify, I am downloading the daily build from NetBeans official page instead 'bits' server directly. So, if
there is a place where I can download the latest builds, just let me know. :)
Comment 12 John Baker 2008-07-22 19:57:51 UTC
hmichel you could try unzipping one of the builds in another directory
http://deadlock.netbeans.org/hudson/job/trunk/lastSuccessfulBuild/artifact/nbbuild/dist/zip/
Comment 13 John Baker 2008-07-23 11:23:16 UTC
sorry this is fixed in my repository but not the main repository
Comment 14 Michel Graciano 2008-07-23 15:26:14 UTC
I can't see the fix for build 20080722174825. The combobox is really huge yet.
Comment 15 John Baker 2008-07-24 00:20:18 UTC
pushed the fix

Sorry for the confusion
Comment 16 Quality Engineering 2008-07-24 04:03:35 UTC
Integrated into 'main-golden', available in NB_Trunk_Production #341 build
Changeset: http://hg.netbeans.org/main/rev/80cdaaf26075
User: John Baker <jbaker@netbeans.org>
Log: #139949 [65cat] SQL History UI must have a maximum size
Comment 17 Michel Graciano 2008-07-24 15:14:35 UTC
Now the Ui is better, but there is some problems as described below.

1-I can't see all the connection name. It should be similar to SQL Command combobox, where the popup is larger that
combobox size.
2-Matching SQL should use all UI extension and a gap as Close button
3-Insert button should have a gap, as Close button

I attached a image about what i am seeing.

Regards.
Comment 18 Michel Graciano 2008-07-24 15:19:01 UTC
Created attachment 65542 [details]
More issues...
Comment 19 John Baker 2008-07-24 22:27:27 UTC
Thanks again for the feedback.
> 1-I can't see all the connection name. It should be similar to SQL Command combobox, where the popup is larger that
combobox size.

I'm on Mac OS X 10.4 , JDK 1.5 and the JCombobox expands to fit the connection items fine.
Could you please provide your environment

> 2-Matching SQL should use all UI extension and a gap as Close button

Other than the width of the Matching SQL textfield, there doesn't appear to be anything else wrong with Matching SQL

> 3-Insert button should have a gap, as Close button

Good catch.  


Comment 20 John Baker 2008-07-24 22:42:13 UTC
> 3-Insert button should have a gap, as Close button
d8915969c2eb
Comment 21 Michel Graciano 2008-07-24 22:44:02 UTC
I totally forgotten about the environment. See below:

Java: 1.6.0_07; Java HotSpot(TM) Client VM 10.0-b23
System: Linux version 2.6.24-20-generic running on i386; ISO-8859-1; pt_BR (nb)
Userdir: /home/michel/.netbeans/dev
Ubuntu 8.04 - Hardy Heron

Regards.
Comment 22 Michel Graciano 2008-07-24 22:46:33 UTC
>> 2-Matching SQL should use all UI extension and a gap as Close button
>Other than the width of the Matching SQL textfield, there doesn't appear to be anything else wrong with Matching SQL
Yep... it is not a issue, just a suggestion to improve the UI width usage. :)
Comment 23 John Baker 2008-07-24 23:49:43 UTC
> 1-I can't see all the connection name. It should be similar to SQL Command combobox, where the popup is larger that
combobox size.

On Mac, the combobox expands for each item, unlike Windows and Linux.

I did increase the width of the combobox, so you could try the latest trunk build.  I may add tooltips for each connection.
Comment 24 John Baker 2008-07-28 05:37:06 UTC
I made some improvements to the layout of the dialog.  
Available in the 28 July build or if not then the latest trunk build
http://hg.netbeans.org/main?cmd=changeset;node=865fd5cd3cdb
Comment 25 Michel Graciano 2008-07-28 14:44:51 UTC
For me, it is really good now. Great work.
I will continue the tests for next versions and any problem I reopen it.
Closing as fixed.
Comment 26 Michel Graciano 2008-07-28 14:45:11 UTC
v. 200807280848
Comment 27 yudiset 2008-07-29 04:07:17 UTC
I voted for this issue.
And on PHP build 20080729001539, it's working great.
It's nice.

Thanks.
Comment 28 John Baker 2008-07-29 19:47:55 UTC
Thank you for your comment and that's great that you're voting.  This also helps prioritize fixes