This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 153841 - Dead code in org.netbeans.modules.j2ee.sun.ide.sunresources.resourceactions.RegisterAction
Summary: Dead code in org.netbeans.modules.j2ee.sun.ide.sunresources.resourceactions.R...
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: pslechta
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-25 10:22 UTC by Martin Fousek
Modified: 2009-02-19 23:04 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Fousek 2008-11-25 10:22:57 UTC 
In the code coverage result wasn't this action covered, so I had a look into sources and repository logs and it seems
so, that this class was changed two years ago. And I installed NetBeans 5.5 and it seems that it's the last IDE, where
was this action used (for registering Sun Application Server Resources on the server).

Please can you check it and when it's a dead code can you please remove it?
Thanks a lot.
Comment 1 Martin Fousek 2008-11-25 10:25:45 UTC 
I'm sorry, I forgot write, that it's code in the file RegisterActions.java in the directory 
{repository}/j2ee.sun.appsrv/src/org/netbeans/modules/j2ee/sun/ide/sunresources/resourceactions.
Comment 2 Vince Kraemer 2008-12-02 21:32:25 UTC 
i expect this can happen in the 7.0 time frame.
Comment 3 pslechta 2008-12-11 13:44:06 UTC 
This is dead code, it is not used anywhere nor registered, and it is not part of API.
Vince, I'm going to remove the RegisterAction and its bundle file if you don't have any objections...
Comment 4 Vince Kraemer 2008-12-11 16:26:34 UTC 
Nitya: this is assigned to you... so you should 'do it or review it'
Comment 5 Nitya Doraisamy 2008-12-11 16:48:57 UTC 
Yes, it can be removed. It wasn't removed initially as I was debating if a 'Register action' would be useful in addition
to the automatic registration as part of deploy. There have been no requests for this to be available again. 

I will go ahead and remove it.
Comment 6 pslechta 2009-01-16 16:13:45 UTC 
Fixed.

http://hg.netbeans.org/main/rev/4e078e73950d
Comment 7 Quality Engineering 2009-01-17 06:55:27 UTC 
Integrated into 'main-golden', will be available in build *200901170201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/4e078e73950d
User: pslechta@netbeans.org
Log: #153841 Dead code in org.netbeans.modules.j2ee.sun.ide.sunresources.resourceactions.RegisterAction
Comment 8 Martin Fousek 2009-01-19 12:25:53 UTC 
Thank you very much for the removing of the dead code.
Comment 9 Nitya Doraisamy 2009-01-20 18:38:42 UTC 
Thanks for cleaning this up.