This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
On the new Mac L&F, all windows around the main area should use consistent background color. Several windows, including the usages window use hard-coded background color. The desired color is #E2E2E2. Please use the following code (provided by saubrecht) to adjust background for mac l&f: if( "Aqua".equals( UIManager.getLookAndFeel().getID() ) ) { setBackground(UIManager.getColor("NbExplorerView.background")); //NOI18N } Further, the usages window has wrong appearance of the control element on the left side of it and annoying frames around it.
( I am not really sure of the correct component, please reassign if necessary )
Created attachment 78461 [details] Wrong color and appearance of the usages window
Created attachment 78462 [details] Wrong color and appearance of the empty usages window
Created attachment 78463 [details] Correct (suggested) appearance of the window background and controls
The background color of the empty Usages top component is not touched by the refactoring module. Should not your patch be part of TopComponent itself? In case of presenting usages the only place touching the background color is TreeCellRenderer that uses JTree.getBackground(). So I will use your patch here.
well, topcomponent is just a JComponent subclass which doesn't paint its background but i'll try fixing that somewhere in window system impl
Created attachment 78962 [details] suggested fix on window system level
i've attached a patch that should take care of most of such issues. please verify that it works for you and i'll push it to main repository then.
Push it there please. I do not have Mac to verify it. The tab containing results fixed as http://hg.netbeans.org/jet-main/rev/32ef45f76dd6
Integrated into 'main-golden', will be available in build *200903281400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/32ef45f76dd6 User: Jan Pokorsky <jpokorsky@netbeans.org> Log: #160658: Wrong apperance of usages window on Mac L&F
patch integrated in core-main 2546947cc9dc it should take care of most of such problems. olangr, can you pls verify that non-editor windows look fine on mac now? thanks
I went through all the windows (hell of a job ;-). Many of them look good, but I identified at least some problems with the following ones: Variables Usages Test Results Call Stack Sources Versioning Output Threads Mercurial CVS Subversion Exception Reporter Javadoc Not sure what to do with those. What is a best way to proceed? Rotating issue, or something like that?
is there a common denominator for those issues that could be fixed in one place? most teams will regard such issues as cosmetic and i'm sure they have plenty of more important bugs to fix:)
To be honest, I can hardly tell. The common denominator is mostly a wrong color of the background. Standa, let's meet and discuss this in person on Monday.
do we still need any fixing in this area?
All important and commonly used windows seem to be OK except for versioning windows: Mercurial, CVS and Subversion. Let's fix these and close it.
reassigning to versioning team
fixed vcs views in core-main #8a7d662289e1 closing...
Integrated into 'main-golden', will be available in build *201103090000* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/8a7d662289e1 User: Tomas Stupka <tstupka@netbeans.org> Log: issue #160658 - Wrong apperance of usages window on Mac L&F