This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Scenario: - Create IO sample - Open io.c file - Find 'argv' string and call context menu. Select Refactor|Rename... menu item - Type 'argv2' and press 'Refactor' button - Press Ctrl-R ==> java.lang.IllegalArgumentException: No highlight contains the caret. at org.netbeans.modules.cnd.refactoring.actions.InstantRenamePerformer.<init>(InstantRenamePerformer.java:126) at org.netbeans.modules.cnd.refactoring.actions.InstantRenamePerformer.performInstantRename(InstantRenamePerformer.java:243) at org.netbeans.modules.cnd.refactoring.actions.InstantRenamePerformer.doInstantRename(InstantRenamePerformer.java:226) at org.netbeans.modules.cnd.refactoring.actions.InstantRenamePerformer.invokeInstantRename(InstantRenamePerformer.java:178) at org.netbeans.modules.cnd.refactoring.actions.InstantRenameAction.actionPerformed(InstantRenameAction.java:62) at org.netbeans.editor.BaseAction.actionPerformed(BaseAction.java:325) at javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1636) at javax.swing.JComponent.processKeyBinding(JComponent.java:2849) at javax.swing.JComponent.processKeyBindings(JComponent.java:2884) at javax.swing.JComponent.processKeyEvent(JComponent.java:2812) at java.awt.Component.processEvent(Component.java:5993) at java.awt.Container.processEvent(Container.java:2041) at java.awt.Component.dispatchEventImpl(Component.java:4583) at java.awt.Container.dispatchEventImpl(Container.java:2099) at java.awt.Component.dispatchEvent(Component.java:4413) at java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1848) at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:704) at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:969) at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:841) at java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:668) at java.awt.Component.dispatchEventImpl(Component.java:4455) at java.awt.Container.dispatchEventImpl(Container.java:2099) at java.awt.Window.dispatchEventImpl(Window.java:2475) at java.awt.Component.dispatchEvent(Component.java:4413) [catch] at java.awt.EventQueue.dispatchEvent(EventQueue.java:599) at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:104) at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269) at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184) at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169) at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161) at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)
fixed http://hg.netbeans.org/cnd-main/rev/7964d9795dbe Please, verify.
Integrated into 'main-golden', will be available in build *200905260201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/7964d9795dbe User: Vladimir Voskresensky <vv159170@netbeans.org> Log: fixed IZ#165960: IllegalArgumentException appears after Ctrl-R
I have reviewed the changes and they are safe and correct. IMHO, we need to integrate the fix into 6.7. One small note: It is bad style to throw uncached exception in EDT thread. Please, replace code: throw new IllegalArgumentException("No highlight contains the caret."); // NOI18N Possible variants: - only log exception - add throws in method definition
reopen to integrate into release67
verified in 200905260201 build from http://bits.netbeans.org/dev/nightly/
please integrate the fix into release67
Would be nice to have this fixed in release67 today (ASAP), thanks in advance.
fix was integrated in 67 http://hg.netbeans.org/release67?cmd=changeset;node=f69cbbef6f2e
verified in NetBeans 6.7rc1