This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 168852 - L10N : untranslated strings in ergonomics HTML files for 6.7.1 Japanese and Chinese
Summary: L10N : untranslated strings in ergonomics HTML files for 6.7.1 Japanese and C...
Status: RESOLVED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: Features On Demand (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-21 08:28 UTC by Masaki Katakai
Modified: 2009-10-05 05:43 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2009-07-21 08:28:40 UTC
I'm now trying NetBeans IDE 6.7.1 (Build 200907202301). When I install
NetBeans IDE by using entire installer, ergonomics is ON. It looks
JavaFX localized HTML files are included in ergonomics cluster as e.g.

org/netbeans/modules/ide/ergonomics/javafx/org-netbeans-modules-javafx-platform-resources-templates-javafxplatformdefinition_ja.html
org/netbeans/modules/ide/ergonomics/javafx/org-netbeans-modules-javafx-project-ui-resources-desktop_ja.html
org/netbeans/modules/ide/ergonomics/javafx/org-netbeans-modules-javafx-project-ui-resources-emptyProject_ja.html
org/netbeans/modules/ide/ergonomics/javafx/org-netbeans-modules-javafx-weather2-WeatherFXApplicationDescription_ja.html

but the following string are all English in them.

  This feature is not yet enabled. Press Next to activate it.

Who prepared the files for Japanese and Chinese?

I don't know the correct location of check-in for these ergonomics files.
Please suggest how to pick up the kit and destination.
Comment 1 Jaroslav Tulach 2009-07-21 09:39:18 UTC
I know where the problem is (not related to javafx at all, it is general problem) and I'll prepare fix asap.
Comment 2 Jaroslav Tulach 2009-07-21 11:38:43 UTC
Fixed as
http://hg.netbeans.org/ergonomics/rev/888d6a136b43
Translators need to provide MSG_NotEnabled key in 
ide.ergonomics/src/org/netbeans/modules/ide/ergonomics/Bundle.properties
and rebuild ide.ergonomics module.

Should this change be backported to 6.7.1, everyone can use:
hg pull -r 888d6a136b43 http://hg.netbeans.org/ergonomics/
hg merge
hg ci -m "Backport of #168852"
Comment 3 Masaki Katakai 2009-07-23 15:14:29 UTC
Thank you for finxing.

I have one question. We're using UTF-8 encoding in all HTML files.
Will it be using UTF-8 encoding at adding the MSG_NotEnabled message?
Comment 4 Jaroslav Tulach 2009-07-24 14:18:59 UTC
I have to admit I did not test the ML build myself. I do not even know how to start it!

As far as UTF-8 goes, yes, that shall be used (untested). 

However my fix requires the Bundle_ja.properties to be at 
ide.ergonomics/src/org/netbeans/modules/ide/ergonomics/Bundle_ja.properties during build time. Is it there? CCing 
Robert and Michal as they may know the answer.
Comment 5 Quality Engineering 2009-07-25 06:22:19 UTC
Integrated into 'main-golden', will be available in build *200907250201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/888d6a136b43
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #168852: Reading 'This feature is not yet enabled...' from a bundle during the build
Comment 6 Michal Zlamal 2009-07-27 14:52:33 UTC
Jardo, localized bundles are not there and there is no plan to have them there
Comment 7 Masaki Katakai 2009-08-03 07:22:37 UTC
Hi,

I prefer not to include any localized HTML files in English
ergonomics module - org-netbeans-modules-ide-ergonomics.jar.
Localized HTML files can be provided by localized module.

Once English HTML files are included in org-netbeans-modules-ide-ergonomics.jar,
we will pick up the HTML files as l10n-kit and will localize them,
then will put into localized repository. We translate all HTML files (other than JavaFX)
in this manner.

Actually JavaFX case is not normal because JavaFX modules contains
both English and localized files in the same jar files. But I think
it's better to follow the usual process for ergonomics.

Michal, what do you think?

Comment 8 Masaki Katakai 2009-10-05 05:43:36 UTC
Hi Jaroslav,

I filed new issue 173718.

Could you please make change not to generate *_ja.*, *_zh_CN.* files for JavaFX?
g11n team is providing localize files in our org-netbeans-modules-ide-ergonomics_<lang>.jar.