This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 169024 - No status suitable for skipped tests
Summary: No status suitable for skipped tests
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Test Runner (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Victor Vasilyev
URL:
Keywords:
Depends on:
Blocks: 160190
  Show dependency tree
 
Reported: 2009-07-23 11:41 UTC by Tomas Mysik
Modified: 2009-09-16 01:07 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
proposed patch (12.83 KB, patch)
2009-09-08 12:41 UTC, Tomas Mysik 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Mysik 2009-07-23 11:41:20 UTC 
Motivation for this issue can be found in issue #160190. Could you please extend test statuses to contain SKIPPED status as well? Thanks a lot.
Comment 1 Alexei Mokeev 2009-07-28 12:24:34 UTC 
Reading #160190 provides good motivation for this change. Let's see if this could be done for 6.8
Comment 2 Tomas Mysik 2009-08-18 15:18:14 UTC 
IMHO it's so trivial that it should be fixed for 6.8. Should I provide a patch for it?
Comment 3 Tomas Mysik 2009-09-08 12:40:29 UTC 
I'm attaching a patch with proposed change (and the change for PHP project).

Please review it and comment, I plan to push it on Thursday or Friday. Thanks.
Comment 4 Tomas Mysik 2009-09-08 12:41:47 UTC 
Created attachment 87264 [details]
proposed patch
Comment 5 Erno Mononen 2009-09-08 13:03:55 UTC 
The patch looks fine to me. 

One idea for improving the api in the future: adding new statuses would be easier if the Status class contained all the 
things that are specific to statuses (color, display names, etc). Now one needs to add conditional logic to several 
places.
Comment 6 Tomas Mysik 2009-09-11 10:57:01 UTC 
I agree with you Erno, this is a mess...

Thanks for the review, I will push on Monday.
Comment 7 Tomas Mysik 2009-09-14 09:20:41 UTC 
Fixed.
http://hg.netbeans.org/web-main/rev/05c3dfc0b4a9
Comment 8 Quality Engineering 2009-09-16 01:07:29 UTC 
Integrated into 'main-golden', will be available in build *200909151512* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/05c3dfc0b4a9
User: Tomas Mysik <tmysik@netbeans.org>
Log: #169024: No status suitable for skipped tests