This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 171971 - [68cat] Commit message text area too big
Summary: [68cat] Commit message text area too big
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Subversion (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker with 2 votes (vote)
Assignee: Ondrej Vrabec
Keywords: UI
Depends on:
Reported: 2009-09-10 19:39 UTC by ulfzibis
Modified: 2013-03-20 20:06 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

SVN commit dialogue (54.99 KB, image/png)
2009-09-10 19:40 UTC, ulfzibis
GIT Commit window (62.95 KB, image/png)
2013-03-07 16:49 UTC, messaged

Note You need to log in before you can comment on or make changes to this bug.
Description ulfzibis 2009-09-10 19:39:29 UTC
[ BUILD # : 200909081533 ]
[ JDK VERSION : 1.6.* ]

See attachment...
Comment 1 ulfzibis 2009-09-10 19:40:33 UTC
Created attachment 87463 [details]
SVN commit dialogue
Comment 2 Ondrej Vrabec 2009-09-10 20:21:36 UTC
I think it's how it's supposed to be. The commit message area takes approximately a half of the dialog (i think it's how
box layout behaves?). Marian, can you evaluate?
Comment 3 Marian Petras 2009-09-10 20:25:22 UTC
I agree we could set some limit of the message area's hight. I suggest that the limit would be 5 lines.
Comment 4 Ondrej Vrabec 2009-09-10 20:35:45 UTC
OK, i agree.
Comment 5 Marian Petras 2009-09-21 15:59:25 UTC
The change is not trivial with the current layout manager (BoxLayout). By setting (in fact, lowering) maximum size of
the message, its resizing weight will be significantly lowered, too. The consequence is that the commit message area
becomes virtually non-resizable, which is not the expected behaviour.

I know of two possible solutions at the moment:

a) Use a custom modified BoxLayout, which would derive resizing weights from the components' preferred sizes and not
from their maximum sizes

b) Use a completely different layout manager for laying out the commit message area and possibly other parts of the
   The problem here is that BoxLayout provides a feature that other layout managers do not provide - it respects maximum
size of components.
Comment 6 ulfzibis 2009-09-21 16:51:47 UTC
> The consequence is that the commit message area becomes virtually non-resizable, which is not the expected behaviour.
I could live with this (I guess, you mean, that on resizing the dialogue, only the files area mainly would be resized),
but I would prefer using JSplitPane to separate the message area from the files area.
Comment 7 Marian Petras 2009-09-21 17:39:07 UTC
Another solution:

Make the text area just 2 or 3 lines high intially. As the user enters more text, resize the text area accordingly. Just
set a limit to (for example) 6 lines, such that when the user starts typing on the seventh line, the message area would
not grow but a scroll bar would appear instead.
Comment 8 ulfzibis 2009-09-21 17:52:47 UTC
> Another solution:
Great, I would like this too, maybe: 2 -> 10 -> scrollbar
Comment 9 messaged 2013-03-07 16:49:51 UTC
Created attachment 132346 [details]
GIT Commit window
Comment 10 Deldadam 2013-03-20 20:06:30 UTC
It is much better now in v7.3. It is implemented not exactly on the way what was asked for, but already better as in earlier releases...

Should we complain more...? :D