This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 177259 - update Java EE 6 XML schemas
Summary: update Java EE 6 XML schemas
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P2 normal (vote)
Assignee: David Konecny
URL:
Keywords:
Depends on:
Blocks: 177500
  Show dependency tree
 
Reported: 2009-11-20 01:13 UTC by David Konecny
Modified: 2009-12-03 04:48 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
schemas update (glassfish-v3-b73-11_19) (450.62 KB, patch)
2009-11-20 01:15 UTC, David Konecny
Details | Diff
update patch (654.51 KB, patch)
2009-11-22 20:18 UTC, David Konecny
Details | Diff
schemas update (glassfish-v3-b73-11_19) (654.51 KB, patch)
2009-11-22 20:19 UTC, David Konecny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Konecny 2009-11-20 01:13:34 UTC
As described on http://wiki.netbeans.org/JEE6ThirdPartyComponents page most of the Java EE 6 XML schemas are not up to date. Once the Java EE 6 is final all schemas should be updated.
Comment 1 David Konecny 2009-11-20 01:15:52 UTC
Created attachment 91390 [details]
schemas update (glassfish-v3-b73-11_19)
Comment 2 David Konecny 2009-11-22 14:06:38 UTC
Testing this patch revealed that validation of web.xml fails because of error in official Java EE 6 schemas. The validation error is:

sch-props-correct.2: A schema cannot contain two global components with the same name; this schema contains two occurrences of 'http://java.sun.com/xml/ns/javaee,descriptionGroup'. [88] nbres:/org/netbeans/modules/j2ee/ddloaders/catalog/resources/javaee_6.xsd 

The problem lies in official Java EE schemas: web-common_3_0.xsd was changed to include javaee_6.xsd instead of javaee_5.xsd, but the problem is that web-common_3_0.xsd also includes jsp_2_2.xsd and that one includes javaee_5.xsd. So result is that both javaee_5.xsd and javaee_6.xsd are being included which then results in "two global components with the same name..." error.

Ludo, Vince, could you contact owner of these schemas and pass the problem to them please? And let me know in which GF build this was resolved?
Comment 3 David Konecny 2009-11-22 20:18:29 UTC
Created attachment 91494 [details]
update patch
Comment 4 David Konecny 2009-11-22 20:19:17 UTC
Created attachment 91495 [details]
schemas update (glassfish-v3-b73-11_19)
Comment 5 David Konecny 2009-11-22 20:20:44 UTC
Patch was updated and validation of web.xml works now. The problem was in jsp_2_2.xsd file not being up to date in NB - now it is part of the patch. Please re-test.
Comment 6 Petr Jiricka 2009-11-23 03:38:57 UTC
Thanks David. I pushed your change to web-main: http://hg.netbeans.org/web-main/rev/b503c84b216a. Michal, can you please test?
Comment 7 Martin Schovanek 2009-11-23 06:09:32 UTC
The patch has been successfully tested by Michal at web-main. Please integrate the fix into release68 branch.
Comment 8 Milan Kuchtiak 2009-11-23 08:45:01 UTC
The fix looks fine now.
The validation works.
Comment 9 Petr Jiricka 2009-11-23 09:34:19 UTC
Fixed in NB 6.8: http://hg.netbeans.org/release68/rev/2dacac21856c
Comment 10 Petr Jiricka 2009-11-23 13:05:01 UTC
Looks like we will need to reopen:
https://glassfish-svn.dev.java.net/servlets/ReadMsg?list=commits&msgNo=17188
Comment 11 Quality Engineering 2009-11-23 18:08:32 UTC
Integrated into 'main-golden', will be available in build *200911231619* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/b503c84b216a
User: pjiricka@netbeans.org
Log: #177259 - updating XML schemas to Java EE 6 version from GlassFish v3 build b73-11_19.
Comment 12 David Konecny 2009-11-23 18:25:40 UTC
Let's keep it open and update schemas just before FCS or earlier if they are finalized.
Comment 13 David Konecny 2009-11-23 20:33:33 UTC
Schema change in https://glassfish-svn.dev.java.net/servlets/ReadMsg?list=commits&msgNo=17188 will be transferred to NB via defect 177400.
Comment 14 Marian Mirilovic 2009-11-24 01:23:29 UTC
> Let's keep it open and update schemas just before FCS or earlier if they are
> finalized.
Davide, are you joking ? Do it now or after FCS, we are 2 weeks after CF and just hours before RC1.
Comment 15 David Konecny 2009-11-24 02:16:34 UTC
Marian, that would not be really a very funny joke, would it? I would do it if XML schemas were final, but they are not. Java EE 6 is close to be finalized but till it is the schemas can still change as illustrated by https://glassfish-svn.dev.java.net/servlets/ReadMsg?list=commits&msgNo=17188 commit. Nothing I can do. If EE6 is defining feature then we should not try to release NB before EE6 and if trying to release them at the same time then we have to be ready to change some files just before release. But you know that.

Let's just keep a close eye on EE6 release and as soon as schemas are finalized we can fix issue 177400.
Comment 16 Petr Jiricka 2009-11-24 06:07:39 UTC
Reopening to keep track of this for FCS, and adding to umbrella bug 177500.
Comment 17 Petr Jiricka 2009-12-02 08:13:06 UTC
Discussed with David that no more updates are needed - closing as FIXED.