This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 177833 - ProjectDefinitionPanel should use AIDPanel for validation
Summary: ProjectDefinitionPanel should use AIDPanel for validation
Status: NEW
Alias: None
Product: javacard
Classification: Unclassified
Component: Java Card (show other bugs)
Version: 6.x
Hardware: PC All
: P4 normal (vote)
Assignee: onkentes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-30 04:48 UTC by dkuzmin
Modified: 2012-08-01 08:41 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dkuzmin 2009-11-30 04:48:10 UTC 
Create a new "Classic Applet Project", in "Create Project" window change "Applet AID" from "//aid/CFCB9269E2/DB" to "//aid/CFCB9269E2/db", start the project. Output:

do-pack:

Packager [v3.0.2]
    Copyright (c) 2009 Sun Microsystems, Inc.
    All rights reserved.
    Use is subject to license terms.

[ INFO: ] Validating Command Line
[ INFO: ] Setting packaging information
[ INFO: ] Package is being created
[ INFO: ] Printing diagnostics..
Module[build]/applet.xml:
    [Error] <path>\ClassicApplet4\build\APPLET-INF\applet.xml parsing failed with the following error: 
        cvc-pattern-valid: Value //aid/CFCB9269E2/db is not facet-valid with respect to pattern //aid/([0-9A-F]{2}){5}/((([0-9A-F]{2}){1,11})|-) for type AIDType.
Packager/create FAILED [1 error(s) and 0 warning(s)]

Build #34 was used.
Comment 1 _ tboudreau 2009-12-01 09:46:01 UTC 
//aid/CFCB9269E2/db is actually illegal according to Anki's validation code (and presumably the Java Card spec).

However, the UI should not allow illegal input and you found the one place where an AID is entered in a text field, rather than AIDPanel which would not allow the user to proceed with illegal input, and it's been in the back of my mind to change that for a long time.
Comment 2 _ tboudreau 2009-12-01 11:59:01 UTC 
Validation input issue fixed in main/ e0c1c898074f - can no longer proceed with lower-case hexadecimal characters.

Keeping this issue open as an enhancement, as for UI consistency it would be preferable to use AIDPanel here, but it would require a more substantial rewrite of ProjectDefinitionPanel than there is time for right now.
Comment 3 Quality Engineering 2009-12-02 14:59:31 UTC 
Integrated into 'main-golden', will be available in build *200912021400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/e0c1c898074f
User: tboudreau@netbeans.org
Log: #177833 - Project wizard allows lower case hexadecimal in Applet AID, but this
violates the spec for AIDs.
Comment 4 _ tboudreau 2011-05-26 01:59:30 UTC 
Reassigning a bunch of bugs still assigned to me - I haven't worked for Oracle in almost a year.
Comment 5 _ tboudreau 2011-05-26 02:44:46 UTC 
Uy... I *am* the default assignee for javacard...
Comment 6 J Bachorik 2012-08-01 08:41:49 UTC 
changing owner