This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 181656 - checkbox for nb module selection is too simple
Summary: checkbox for nb module selection is too simple
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Maven (show other bugs)
Version: 6.x
Hardware: All All
: P3 normal (vote)
Assignee: Jesse Glick
URL:
Keywords:
Depends on: 204546
Blocks:
  Show dependency tree
 
Reported: 2010-03-09 00:28 UTC by Milos Kleint
Modified: 2011-11-01 21:12 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Failed patch (4.84 KB, patch)
2010-11-17 15:29 UTC, Jesse Glick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Milos Kleint 2010-03-09 00:28:23 UTC
the checkbox for nb module only dependency search is nice, but a bit simplistic. it will return both false positive and false negative results.
1. the nb repository contains not only nbm artifacts but also cluster poms and external jar libs.
2. some modules could be present in other repositories
3. for people behind nexus/artifactory/archive, this list will return nothing. (if they have the nb repository list changed to point just to the repository manager instance.

possible solutions:
1. search for artifacts with "nbm" packaging. the netbeans repo generated with the nbm:populate-repository might need patching as well to include the packaging into the generated content. And fix the already released bits and reindex the current repository?
2. have nexus to add a boolean searchable field that will mark the artifact as nb module. For possibly easier and faster acceptance of the patch, the same boolean field could be created for osgi. Both should be based on the manifest field within the jar file. nb could also check presence of nbm artifact.
Then our job would be just to include the boolean into the  query.
Comment 1 Jesse Glick 2010-11-17 15:29:25 UTC
Created attachment 103038 [details]
Failed patch

Does not work to limit results to nbm packaging. This shows results only for RELEASE70-BETA - some kind of change in how the repo was indexed?

BTW I tried to add FIELD_PACKAGING/TYPE_NBM/MATCH_EXACT/OCCUR_MUST to the regular clause list but then other clauses are ignored, i.e. *all* nbm-packaging artifacts match regardless of the search text. I hate Lucene; what would be a trivial

  packaging = 'nbm' and (artifact like 'foo' or group like 'foo' or ...)

in a SQL database seems to be impossible.
Comment 2 Jesse Glick 2010-11-23 18:37:14 UTC
A revised patch does work with a rebuilt index that includes both *.jar and *.nbm artifacts, so I will push the fix once Robert makes that live.
Comment 3 Jesse Glick 2010-11-24 17:22:04 UTC
core-main #ceac3db5a1e4
Comment 4 Quality Engineering 2010-11-25 06:20:03 UTC
Integrated into 'main-golden', will be available in build *201011250001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/ceac3db5a1e4
User: Jesse Glick <jglick@netbeans.org>
Log: #181656: "NB Only" should search for NBM artifacts anywhere.