The problem is (I think) that code generated for Facelets requires EE 6 (uses EJB in Web app??) and therefore it cannot be generated for EE 5 app. Alexey, could you have a look and confirm please? Would it be hard to rewrite the generated code to run on EE 5?

I'm encountering this problem as well. I am using Java EE 6. Additionally, when I added the framework through the IDE, I set Facelets as the preferred page language. However, when I view it again, JSP is set. No matter how many times I change this JSP is still set as the preferred page language. I am using Java EE 6, GlassFish 3, NetBeans 6.9, and Windows 7.

Update: I had removed the dependencies from the POM for jsf-api, jsf-impl, jstl, and the standard taglibs, as I already had javaee-web-api defined and the implementation was provided by GlassFish. After adding these back, the pages were created properly, using facelets instead of jsp.

(In reply to comment #1)
> The problem is (I think) that code generated for Facelets requires EE 6 (uses
> EJB in Web app??) and therefore it cannot be generated for EE 5 app. Alexey,
> could you have a look and confirm please? Would it be hard to rewrite the
> generated code to run on EE 5?

Yes, the code requires EE6 because of the EJB 3.1. It is not hard, but it will take some time, since there are a mess in the code for generating JSF entities.

(In reply to comment #4)
> Yes, the code requires EE6 because of the EJB 3.1. It is not hard, but it will
> take some time, since there are a mess in the code for generating JSF entities.

Yeah, it is messy. I branched code generator for Facelets and it uses customizable templates. My motivation was to leave old Java API based generator as it was. And similarly I would not want to complicate new template based code generator. Unless there is a simple way which would not increase complexity (ie. messiness). Let me know please how would you fix this before you head that way so that we can review it first. Thx.

Created attachment 101340 [details]
patch

(In reply to comment #5)
> (In reply to comment #4)
> > Yes, the code requires EE6 because of the EJB 3.1. It is not hard, but it will
> > take some time, since there are a mess in the code for generating JSF entities.
> 
> Yeah, it is messy. I branched code generator for Facelets and it uses
> customizable templates. My motivation was to leave old Java API based generator
> as it was. And similarly I would not want to complicate new template based code
> generator. Unless there is a simple way which would not increase complexity
> (ie. messiness). Let me know please how would you fix this before you head that
> way so that we can review it first. Thx.

I've attached the patch for you to review.

Cc'ing also Sergey so he can review the JPA part of the patch.

Alexey, I am trying out your patch - the generated code looks good, but does not quite work with WebLogic.

When I access the generated listing pages, then the Chrome browser outputs:
error on line 11 at column 15: Encoding error
Firefox displays question marks in some places.

BTW, the generated facelet encoding is ISO-8859-1  - shouldn't this be UTF-8?

Next, the server console contains the following warnings:

WARNING: JSF1063: WARNING! Setting non-serializable attribute value into HttpSession (key: customerJpa, value class: p.CustomerJpaController).
WARNING: JSF1063: WARNING! Setting non-serializable attribute value into HttpSession (key: customerController, value class: p.CustomerController).

Created attachment 101410 [details]
updated patch

Petr, 

I've updated the patch according to your comments.

(In reply to comment #9)
> Alexey, I am trying out your patch - the generated code looks good, but does
> not quite work with WebLogic.
> 
> When I access the generated listing pages, then the Chrome browser outputs:
> error on line 11 at column 15: Encoding error
> Firefox displays question marks in some places.
> 
> BTW, the generated facelet encoding is ISO-8859-1  - shouldn't this be UTF-8?
> 
> Next, the server console contains the following warnings:
> 
> WARNING: JSF1063: WARNING! Setting non-serializable attribute value into
> HttpSession (key: customerJpa, value class: p.CustomerJpaController).
> WARNING: JSF1063: WARNING! Setting non-serializable attribute value into
> HttpSession (key: customerController, value class: p.CustomerController).

Looks good. One or two thing needs to be changed:

* <Entity>JpaController class should not be managed bean. It should have constructor accepting (UserTransaction utx, EntityManagerFactory emf). That way class can be used in different context for example from JSF managed beans, web services etc. It is job of whoever is using <Entity>JpaController to retrieve UserTransaction and EntityManagerFactory.

* <Entity>Controller class should have UserTransaction and EntityManagerFactory injected and should create <Entity>JpaController lazily in getJpaController() method

* <Entity>ControllerConverter class should retrieve <entity>Controller property and call on it getJpaController().

Created attachment 101432 [details]
one more change

and you probably want to do also this

Created attachment 101446 [details]
patch

Patch updated according to the latest comments.

Hi Alexey, I tested it and it looks good. If David has no other comments, you can check it in and we will deal with any outstanding issues later.

(In reply to comment #16)
> Hi Alexey, I tested it and it looks good. If David has no other comments, you
> can check it in and we will deal with any outstanding issues later.

If patch works and addresses the issues identified then go ahead and push it. Thx.

http://hg.netbeans.org/web-main/rev/ce83e94c8d02

Integrated into 'main-golden', will be available in build *201008190001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/ce83e94c8d02
User: Alexey Butenko <alexeybutenko@netbeans.org>
Log: #188602: JSF pages from entity for EE 5 uses JSP even if Facelets is set as the default page language

*** Bug 185491 has been marked as a duplicate of this bug. ***