This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 188706 - ExtractLayer problem with missing final newline
Summary: ExtractLayer problem with missing final newline
Status: RESOLVED FIXED
Alias: None
Product: ide
Classification: Unclassified
Component: Features On Demand (show other bugs)
Version: 7.0
Hardware: PC Linux
: P4 normal (vote)
Assignee: Jaroslav Tulach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-15 16:32 UTC by Jesse Glick
Modified: 2010-08-18 03:24 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2010-07-15 16:32:22 UTC 
I believe that the failure in

http://bertram.netbeans.org/hudson/job/web-main/3513/testReport/junit/org.netbeans.modules.ide.ergonomics/LibrariesCheck/testCheckLibrariesPretest/

Wrong name of jsf12ri.xml old: JSF 1.2 RI new: JSF 1.2 RI# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.

(preventing web-main propagation) apparently caused by

http://hg.netbeans.org/web-main/diff/c03db73b2b0d/web.jsf12ri/src/org/netbeans/modules/web/jsf12ri/Bundle.properties

+jsf12ri=JSF 1.2 RI
\ No newline at end of file

is a bug in ExtractLayer. It appears to concatenate a number of strings - file bodies? - together and then somehow process them - load as a *.properties? If a final newline is missing, perhaps it tries to load

...
jsf12ri=JSF 1.2 RI# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS HEADER.
#
# Copyright 1997-2010 Oracle and/or its affiliates. All rights reserved.
...

which is of course wrong.

If so, simple workaround would be for Alexey to insert the final newline in Bundle.properties.
Comment 1 Petr Jiricka 2010-07-16 08:01:38 UTC 
Alexey indeed applies this workaround: http://hg.netbeans.org/web-main/rev/7fe069abf75e
Comment 2 Jaroslav Tulach 2010-07-16 09:02:33 UTC 
To Jiřička: "this workaround" - you wanted to say "fix".

I don't think that breaking build by messing source files, should be treated as P1 for the build infrastructure. Especially if the infrastructure helped you correctly detect the problem and prevent propagation of changes.

The bug seems to be fix by 7fe069abf75e. grep web.jsf12ri .nbbugzilla-components yeilds javaee/jsf. Moving there and marking fixed. In case you believe infrastructure needs improvements feel free to report separate enhancement which will be addressed appropriately.
Comment 3 Jesse Glick 2010-07-16 15:14:18 UTC 
No, this was a workaround; the original code in JSF was correct (there is no requirement that a *.properties file end in a newline). It is FoD that was incorrectly assuming that all such files do end in a newline. No longer a P1 since the trigger condition for the bug has been removed.
Comment 4 Jesse Glick 2010-07-16 15:17:09 UTC 
No longer a blocking issue.
Comment 5 Jaroslav Tulach 2010-08-16 17:20:06 UTC 
ergonomics#91c2e99cc715
Comment 6 Quality Engineering 2010-08-18 03:24:53 UTC 
Integrated into 'main-golden', will be available in build *201008180001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/91c2e99cc715
User: Jaroslav Tulach <jtulach@netbeans.org>
Log: #188706: Deal with files without end of line