This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 192293 - don't generate dmake specific syntax in makefiles
Summary: don't generate dmake specific syntax in makefiles
Status: RESOLVED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Project (show other bugs)
Version: 6.x
Hardware: PC Mac OS X
: P2 normal (vote)
Assignee: Thomas Preisler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-22 18:07 UTC by Thomas Preisler
Modified: 2010-11-24 06:11 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Preisler 2010-11-22 18:07:01 UTC
I see several constructions in makefile generator like this:

boolean dMake = isDMake(compilerSet);
...
//Fix for #180918: Multiple make targets incompatible with GNU make
if (dMake) {
  target = customToolConfiguration.getOutputs().getValue(" + "); // NOI18N
} else {
  target = customToolConfiguration.getOutputs().getValue();
}

This is wrong and breaks one of the big rules for our projects: the generated makefiles are make syntax agnostic. Meaning a generated makefile should work equally well with make, dmake, and gmake regardless where they were generated and with what tool chain. The make tool in *not* and should not be saved with the project. The reason is you don't know how the makefile is being invoked. The project may be part of a bigger build system and we don't have control over what make is being used there.

There should always be a make construction that work with all the makes. It has been true in the past so it is probably also tru in this case.
Comment 1 Thomas Preisler 2010-11-23 02:25:51 UTC
the following code should work on all platforms and all makes

.NO_PARALLEL:y.tab.c y.tab.h
y.tab.c y.tab.h: token.y
        @echo Running yacc...
        yacc -d token.y
Comment 2 Thomas Preisler 2010-11-23 18:02:06 UTC
fixed.
Comment 3 Quality Engineering 2010-11-24 06:11:57 UTC
Integrated into 'main-golden', will be available in build *201011240001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/d877e792315f
User: Thomas Preisler <thp@netbeans.org>
Log: #192293 - don't generate dmake specific syntax in makefiles