This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 19517 - drawing of line annotations in NB3.3 editor is NOT backward compatible
Summary: drawing of line annotations in NB3.3 editor is NOT backward compatible
Status: CLOSED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: David Konecny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-01-17 09:58 UTC by David Konecny
Modified: 2007-11-05 13:42 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
testing application (1.17 KB, text/plain)
2002-01-17 16:51 UTC, David Konecny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Konecny 2002-01-17 09:58:37 UTC
OpenIDE API methods Line.markBreakpoint() and Line.markCurrent() were deprecated 
for NetBeans 3.3, because they were replaced by new Anntations API.

When these deprecated methods are used, the lines in editor are not annotated,
because the old code was disabled and only new Annotation API is supported. This 
causes that editor is NOT backward compatible. If anybody install NetBeans3.2 
module into NetBeans3.3, the calls to deprecated API will not annotate line.
Comment 1 David Konecny 2002-01-17 16:48:21 UTC
This is easy to fix. *Fortunately* I did not remove this functionality 
from editor. I just disabled drawing of breakpoints and current lines 
after the debuggercore has switched to new Annotation API. And so all 
what is necessary to do is to revert that change. That change was done 
as revision:

<http://editor.netbeans.org/source/browse/editor/libsrc/org/netbeans/e
ditor/DrawLayerFactory.java.diff?r1=1.37&r2=1.38>

and I reverted it in main trunk as revision:

<http://editor.netbeans.org/source/browse/editor/libsrc/org/netbeans/e
ditor/DrawLayerFactory.java.diff?r1=1.40&r2=1.41>

I tested the fix following way:
* I started IDE and verified that all new annotation functionality 
stayed intact: I added some breakpoints, debug simple app and simulate 
compiler errors. All anntotions work fine
* I wrote a simple application which uses deprecated API and execute 
it and old annotations appeared in editor. I will attach this 
application to this issue. Just store it in "test" package and execute 
it with Internal Executor. After that you should see all three types 
of old annotations: current line, error line and breakpoint line

I would like to ask for approval for integrating this fix into 
NB 3.3.1.

Thank you.
Comment 2 David Konecny 2002-01-17 16:51:46 UTC
Created attachment 4248 [details]
testing application
Comment 3 eadams 2002-01-17 18:56:02 UTC
Approved.  I'm very pleased to see backward compatibility
problems discovered and fixed.
Comment 4 Jan Chalupa 2002-01-17 21:53:52 UTC
Approved by QA.
Comment 5 iformanek 2002-01-18 08:06:59 UTC
Approved
Comment 6 David Konecny 2002-01-18 14:43:52 UTC
Integrated into 3.3.1.
Comment 7 Quality Engineering 2003-06-30 18:04:28 UTC
Resolved for 3.3.x or earlier, no new info since then -> closing.
Comment 8 Quality Engineering 2003-06-30 18:10:44 UTC
Resolved for 3.3.x or earlier, no new info since then -> closing.