This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 199528 - Paamayim Nekudotayim (double colon) added behind class name after typing extends or implements and selecting a class using code completion
Summary: Paamayim Nekudotayim (double colon) added behind class name after typing exte...
Status: VERIFIED FIXED
Alias: None
Product: php
Classification: Unclassified
Component: Editor (show other bugs)
Version: 7.0.1
Hardware: PC Windows 7 x64
: P2 normal with 1 vote (vote)
Assignee: Petr Pisl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-19 16:52 UTC by maghiel
Modified: 2011-06-23 04:41 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description maghiel 2011-06-19 16:52:47 UTC 
Paamayim Nekudotayim (double colon) added behind class name after typing extends or implements and selecting a class using code completion. 

Steps to reproduce:
<?php
class newPHPClass
    extends [ctrl+space] [select SPLObserver]
{
}
?>

Expected result:
<?php
class newPHPClass
    extends SPLObserver
{
}
?>

Actual result:
<?php
class newPHPClass
    extends SPLObserver::
{
}
?>

Same happens with the implements keyword.
This issue has been around for some time as well, but did not have time to report again Petr ;)

Additionally, I ran into http://statistics.netbeans.org/analytics/exception.do?id=515243 when reproducing the issue to file this report.
Steps to reproduce:
<?php
class newPHPClass
    extends SPLObserver
{
}
?>

<?php
class newPHPClass
->    implements [ctrl+space] [select interface to implement]
    extends SPLObserver
{
}
?>

Environment:
Product Version: NetBeans IDE Dev (Build nbms-and-javadoc-7200-on-20110515)
Java: 1.7.0-ea; Java HotSpot(TM) 64-Bit Server VM 21.0-b14
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
Userdir: C:\Users\maghiel\.netbeans\dev
Comment 1 Petr Pisl 2011-06-20 12:01:14 UTC 
I can reproduce. There is important that the extends keyword has to be on the next line. It looks like that the context is not counted properly in such case. I would say it's almost P2.
Comment 2 Petr Pisl 2011-06-20 15:30:58 UTC 
Fixed in web-main. http://hg.netbeans.org/web-main/rev/d64d63352972

QA could you please test it? I would like to integrate this into release 7.0.1
Comment 3 Vladimir Riha 2011-06-20 15:44:23 UTC 
I'll verify it today (if possible) or by wednesday morning
Comment 4 maghiel 2011-06-20 15:45:53 UTC 
Thanks for the fast work Petr :)
Will this change be included in the next nightly? If so, I'll verify as soon as it's available.
Comment 5 rmatous 2011-06-20 15:55:58 UTC 
Seems fine to me
Comment 6 Petr Pisl 2011-06-20 16:32:48 UTC 
I have committed one more change, that fix one more problem with this. Should be available in daily build tomorrow, if everything will be ok.
Comment 7 Petr Pisl 2011-06-20 16:33:10 UTC 
http://hg.netbeans.org/web-main/rev/2ad9f59da9f1
The last change.
Comment 8 maghiel 2011-06-20 17:34:54 UTC 
Will verify tomorrow, thanks!
Comment 9 maghiel 2011-06-21 00:31:19 UTC 
Problem persists in:
Product Version: NetBeans IDE Dev (Build 201106200600)
Java: 1.7.0-ea; Java HotSpot(TM) 64-Bit Server VM 21.0-b14
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
Userdir: C:\Users\maghiel\.netbeans\dev

Should I wait for the next nightly?
Comment 10 Petr Pisl 2011-06-21 09:19:11 UTC 
Could you try one of the latest continual build at bertram? http://bertram.netbeans.org/hudson/job/PHP-build/ 

I'm not sure, whether the change was applied into the daily build. 
Thanks.
Comment 11 maghiel 2011-06-21 15:56:29 UTC 
Thanks, forgot the url to the continueus builds.
Will verify within the hour.
Comment 12 Quality Engineering 2011-06-21 16:04:13 UTC 
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/d64d63352972
User: Petr Pisl <ppisl@netbeans.org>
Log: #199528 - Paamayim Nekudotayim (double colon) added behind class name after typing extends or implements and selecting a class using code completion
Comment 13 maghiel 2011-06-21 16:31:33 UTC 
Verified fixed in:

Product Version: NetBeans IDE Dev (Build 2011-06-21_15-04-02 )
Java: 1.6.0_23; Java HotSpot(TM) Client VM 19.0-b09
System: Windows 7 version 6.1 running on x86; Cp1252; nl_NL (nb)
Userdir: C:\Users\maghiel\.netbeans\dev
Comment 14 Petr Pisl 2011-06-22 16:37:32 UTC 
The changes are transplanted in releases/release701 branch now
Comment 15 Quality Engineering 2011-06-23 04:41:11 UTC 
Integrated into 'releases'
Changeset: http://hg.netbeans.org/releases/rev/b7c419784d06
User: Petr Pisl <ppisl@netbeans.org>
Log: #199528 - Paamayim Nekudotayim (double colon) added behind class name after typing extends or implements and selecting a class using code completion
(transplanted from d64d6335297295bb3fc3a76261fd67d51fede7e2)