This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 202243 - GSP syntax highlighting gets confused by "\${"
Summary: GSP syntax highlighting gets confused by "\${"
Status: RESOLVED FIXED
Alias: None
Product: groovy
Classification: Unclassified
Component: GSP (show other bugs)
Version: 7.0.1
Hardware: PC Mac OS X
: P3 normal (vote)
Assignee: Martin Janicek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-16 16:08 UTC by athompson
Modified: 2012-03-28 03:34 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
highlighting confused by the 'else' statement (45.52 KB, image/png)
2012-03-27 15:22 UTC, athompson 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description athompson 2011-09-16 16:08:29 UTC 
this is legal in a template, for example:

  <g:if test="\${flash.message}">

Afterwords, the highlighting is confused.
Comment 1 Martin Janicek 2012-03-19 08:48:32 UTC 
Still valid issue, but this is quite minor --> Changing TM to Next
Comment 2 athompson 2012-03-21 11:04:08 UTC 
I'm not sure I agree this is minor since the highlighting is confused for several (potentially many) lines.
Comment 3 Martin Janicek 2012-03-21 11:07:38 UTC 
Ok, I'll take a look on it
Comment 4 Martin Janicek 2012-03-21 15:56:25 UTC 
Problem seems to be in HTML highlighting. Reassigning for evaluation. Following code is a valid HTML, but it's highlighted incorrectly.

<html>
  <body data-test="\${}">
  </body>
</html>
Comment 5 Martin Janicek 2012-03-21 16:51:52 UTC 
Sorry Marek, I was wrong :] .. it's only groovy/gsp related --> Reassigning back to me
Comment 6 Martin Janicek 2012-03-22 13:37:57 UTC 
Fixed in: web-main #996b07c2e800
Comment 7 Quality Engineering 2012-03-23 10:35:29 UTC 
Integrated into 'main-golden', will be available in build *201203230400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/996b07c2e800
User: Martin Janicek <mjanicek@netbeans.org>
Log: #202243 - GSP syntax highlighting gets confused by "\${"
Comment 8 athompson 2012-03-27 15:19:38 UTC 
There is another, very closely related problem (see attachment).  Do you want me to add it here or open a new ticket?
Comment 9 athompson 2012-03-27 15:22:28 UTC 
Created attachment 117352 [details]
highlighting confused by the 'else' statement
Comment 10 athompson 2012-03-27 17:02:45 UTC 
More precisely, highlighting is confused by the "$('#searchText').val(null);' statement after the 'else', even though it's highlighted correctly directly above.
Comment 11 Martin Janicek 2012-03-28 03:34:11 UTC 
Please, fill a new issue about that one. And if possible provide some minimal reproducible code sequence.