This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 204817 - Review of ConstrainedBinaryIndexer
Summary: Review of ConstrainedBinaryIndexer
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Parsing & Indexing (show other bugs)
Version: 7.1
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Zezula
URL:
Keywords: API, API_REVIEW_FAST, PERFORMANCE
Depends on:
Blocks: 200050
  Show dependency tree
 
Reported: 2011-11-08 09:30 UTC by Tomas Zezula
Modified: 2011-11-11 15:36 UTC (History)
2 users (show)

See Also:
Issue Type: TASK
Exception Reporter:

Attachments
Patch file (38.51 KB, patch)
2011-11-08 12:22 UTC, Tomas Zezula 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Zezula 2011-11-08 09:30:38 UTC 
Added ConstrainedBinaryIndexer which  allows an indexer to declaratively specify constrains which need to be fulfilled, the check is done by infrastructure before the indexer is loaded. If the constrains are not fulfilled the indexer is neither loaded nor executed.
Comment 1 Martin Fousek 2011-11-08 12:08:12 UTC 
Probably missing patch?
Comment 2 Tomas Zezula 2011-11-08 12:22:16 UTC 
Created attachment 112994 [details]
Patch file
Comment 3 Jesse Glick 2011-11-08 16:01:18 UTC 
[JG01] Typo - "constrains" (as a noun) should be "constraints" (several places).


[JG02] "paths inside the binary files" seems vague.


[JG03] XSD_MIME = "text/xml" seems odd; IIRC there is a special MIME subtype inside NB for *.xsd.
Comment 4 Tomas Zezula 2011-11-08 16:16:23 UTC 
JG01 + JG02 : Fixed

JG03: Yes we have mime resolver for xsd but the XSD mime resolver returns text/xml as mime type.
Comment 5 Jesse Glick 2011-11-08 16:27:52 UTC 
JG03 - then maybe that should be fixed now. AFAIK should be harmless for existing code to switch the resolver to producing a subtype.
Comment 6 Jaroslav Tulach 2011-11-10 09:42:54 UTC 
Overall concept seems fine.

Y01 Javadoc for mimeType() is wrong "Use <code>{}</code> if the resource check should be skipped" - it should not talk about resources.

Y02 Slightly unrelated, but don't forget to make parsing.api stable - change nbbuild/build.properties and parsing.api/arch.xml
Comment 7 Tomas Zezula 2011-11-10 10:32:50 UTC 
Y01: Fixed
Y02: Next week
Comment 8 Tomas Zezula 2011-11-10 11:03:33 UTC 
Fixed jet-main d054f910d8f6
Comment 9 Quality Engineering 2011-11-11 15:36:12 UTC 
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/d054f910d8f6
User: Tomas Zezula <tzezula@netbeans.org>
Log: #204817:Review of ConstrainedBinaryIndexer