This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Hi, I am opening this task to offer refactoring of profiler cluster to new @DataObject.Registration and some related cleaning (i.e. using constant) Some Loader related action will also be patched. I first need to have agreement of assignee to review change and then I will work on the patch.
(In reply to comment #0) > I first need to have agreement of assignee to review change and then I will > work on the patch. You can work on patch. I will review it. Thanks.
Created attachment 118201 [details] Proposed convertion of profiler cluster Hi this is the first proposal for the migration. I note with XXX 3 lines wich are not used at my point of view. mimeresolver resolve to application/x-netbeans-profiler but a x-application/nps was present in the layer.xml file for an obscure reason to me. Same for npss and hprof. profiler seems to react the same without thoose line. Let me know if I can remove the XXX lines Regards
(In reply to comment #2) > Created attachment 118201 [details] > Proposed convertion of profiler cluster > > Hi this is the first proposal for the migration. > > > I note with XXX 3 lines wich are not used at my point of view. > mimeresolver resolve to application/x-netbeans-profiler but a x-application/nps > was present in the layer.xml file for an obscure reason to me. > > Same for npss and hprof. > profiler seems to react the same without thoose line. I need to do some more investigation, but it looks to me that the mime types for the profiler DataObjects are: x-application/hprof x-application/npss x-applicaiton/nps The patch contains unrelated changes to actions, adding @Override and some white space changes to the original code. Can you please, make sure that the patch just address registration of DataObject via new @DataObject.Registration annotation. Thanks.
The actions migrated into actionreference are only the one in the Loaders folder of the layer and was for me part to the convertion (maybe not well written in comment #1). I think its better to have all this done in one changeset. Let me know. sorry for @override. Reverting this. into NpsResolver.xml I found: <file> <ext name="nps"/> <resolver mime="application/x-netbeans-profiler"/> </file> Maybe it can be rewritten to <file> <ext name="nps"/> <resolver mime="x-application/nps"/> </file> Regards
Thanks for the proposed patch, I will apply it with some modifications.
Fixed in profiler-main changeset: 221104:0190c0405f0d user: Tomas Hurka <thurka@netbeans.org> date: Mon May 07 11:38:51 2012 +0200 summary: issue #211017, use @DataObject.Registration annotation
One more DataObject: changeset: 221105:27b589f0314c user: Tomas Hurka <thurka@netbeans.org> date: Mon May 07 13:20:36 2012 +0200 summary: issue #211017, use @DataObject.Registration annotation
Integrated into 'main-golden', will be available in build *201205100400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/0190c0405f0d User: Tomas Hurka <thurka@netbeans.org> Log: issue #211017, use @DataObject.Registration annotation
Hi Tomas, should I create another issue for the actions related to the loaders part of the xml layer related to this ? Regards
(In reply to comment #9) > should I create another issue for the actions related to the loaders part of > the xml layer related to this ? No, since custom actions was removed. See http://hg.netbeans.org/profiler-main/rev/94df6bf5a628