This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 211717 - Some profiler dialogs need help #4
Summary: Some profiler dialogs need help #4
Status: RESOLVED FIXED
Alias: None
Product: profiler
Classification: Unclassified
Component: Base (show other bugs)
Version: 7.2
Hardware: All All
: P3 normal (vote)
Assignee: Kenneth Ganfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-25 14:04 UTC by jtau8042
Modified: 2012-05-15 15:57 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
fix (16.42 KB, patch)
2012-05-09 12:47 UTC, jtau8042
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jtau8042 2012-04-25 14:04:16 UTC

    
Comment 1 jtau8042 2012-05-03 14:26:26 UTC
Following dialogs are missing help button:

1) CPU Snapshot -> "Info" tab -> Edit user comments -> "Edit User Comments" dialog
2) CPU Snapshot -> "Call Tree" tab -> Add to instrumentation roots.. -> "Select Settings Configuration" dialog
3) CPU Snapshot -> Profiler control panel -> Rename snapshot -> "Rename Snapshot" dialog
4) Heap Dump -> "Classes" tab -> Compare with another.. -> "Select Heap Dump to Compare" dialog
Comment 2 jtau8042 2012-05-09 12:47:00 UTC
Created attachment 119200 [details]
fix
Comment 3 Jiri Sedlacek 2012-05-09 13:01:04 UTC
Looking at the diff, 'import javax.swing.border.EmptyBorder;' doesn't seem to be required in ProfilerControlPanel2.java.

In SnapshotInfoPanel.java please use 'BorderFactory.createEmptyBorder(...)' instead of 'new EmptyBorder(...)' and remove the EmptyBorder import as well.

OK to integrate once the above mentioned problems are fixed.
Comment 4 jtau8042 2012-05-09 14:34:36 UTC
Changeset: http://hg.netbeans.org/profiler-main/rev/7b207783490e
Comment 5 jtau8042 2012-05-09 14:43:29 UTC
fixed typo in help context id
Changeset: http://hg.netbeans.org/profiler-main/rev/c6796cbca989
Comment 6 jtau8042 2012-05-09 14:44:11 UTC
added following Help Topic IDs
1) "Edit User Comments" dialog: 
   EditUserComments.HelpCtx
2) "Select Settings Configuration" dialog:
   SelectSettingsConfiguration.HelpCtx       
3) "Rename Snapshot" dialog:          
   ProfilerControlPanel.RenameSnapshot.HelpCtx
4) "Select Heap Dump to Compare" dialog: 
   SelectSecondSnapshot.HelpCtx
Comment 7 Kenneth Ganfield 2012-05-11 15:39:38 UTC
How are the following dialogs invoked?

"Edit User Comments" dialog
"Select Settings Configuration" dialog
Comment 8 Quality Engineering 2012-05-12 09:56:58 UTC
Integrated into 'main-golden', will be available in build *201205120400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/7b207783490e
User: Jan Taus <jtau8042@netbeans.org>
Log: #211717: Some profiler dialogs need help #4
Comment 9 jtau8042 2012-05-14 11:32:12 UTC
"Edit User Comments"
1) Take CPU snapshot while CPU profiling (or open previously saved snapshot in Profiler tab)
2) Switch to "Info" tab on bottom line of CPU snapshot window.
3) Click on "edit..." link on "User comments" line

"Select Settings Configuration"
1) Take CPU snapshot while CPU profiling (or open previously saved snapshot in Profiler tab)
2) Switch to "Call Tree" tab on bottom line of CPU snapshot window.
3) Right-click on line with methon in the table.
4) Select "Add to instrumentation roots..." in pop-up menu
Comment 10 Kenneth Ganfield 2012-05-14 17:22:04 UTC
Added drafts
http://hg.netbeans.org/main/rev/044a64eec10b
Comment 11 Quality Engineering 2012-05-15 10:11:51 UTC
Integrated into 'main-golden', will be available in build *201205150400* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/044a64eec10b
User: kganfield <kganfield@netbeans.org>
Log: #211717, add drafts of new profiler topics, update map file
Comment 12 Kenneth Ganfield 2012-05-15 15:57:51 UTC
Topics are working in recent build. Marking as fixed.