This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 215909 - remote files should not be fetched in AWT thread
Summary: remote files should not be fetched in AWT thread
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Project (show other bugs)
Version: 7.3
Hardware: All All
: P2 normal (vote)
Assignee: Martin Entlicher
URL:
Keywords:
: 217261 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-07-24 23:52 UTC by David Konecny
Modified: 2012-09-10 22:23 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
thread dump (57.16 KB, text/plain)
2012-07-24 23:52 UTC, David Konecny 		Details
newer threaddump (31.28 KB, text/plain)
2012-08-23 02:03 UTC, David Konecny 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Konecny 2012-07-24 23:52:17 UTC 
Created attachment 122327 [details]
thread dump

Martin,

my proxy server was misconfigured and I noticed this stack trace in AWT thread:

sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:849)
o.n.modules.web.clientproject.remote.RemoteFS.getFileForURL(RemoteFS.java:139)
o.n.modules.web.clientproject.ui.ClientSideProjectLogicalView$RemoteFilesChildren.createNodes(ClientSideProjectLogicalView.java:263)

Could this be moved outside of AWT thread? Previously I implemented it like this: when remote file is not in cache yet then an empty file is create with text "file xxx is being downloaded" and returned this FO immediately and started in separate background thread downloading that file. When remote file was downloaded the content would be swapped which fired FileChange event and editor automatically reloaded the real content.
Comment 1 David Konecny 2012-08-23 01:56:24 UTC 
This could potentially be troublesome. Let's fix it earlier than late.
Comment 2 David Konecny 2012-08-23 02:03:41 UTC 
Created attachment 123434 [details]
newer threaddump
Comment 3 David Konecny 2012-08-23 02:04:29 UTC 
Happens for example when I'm on OWAN but IDE does not have a proxy configured. The result is locked IDE which has to be killed.
Comment 4 Martin Entlicher 2012-08-23 15:41:16 UTC 
Fixed by changeset:   230790:2e0a551d51df
http://hg.netbeans.org/web-main/rev/2e0a551d51df
Comment 5 Quality Engineering 2012-09-03 13:04:05 UTC 
Integrated into 'main-golden', will be available in build *201209031048* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/2e0a551d51df
User: mentlicher@netbeans.org
Log: #215909: It looks like the check for a valid connection is not necessary.
Comment 6 David Konecny 2012-09-10 22:23:58 UTC 
*** Bug 217261 has been marked as a duplicate of this bug. ***