This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 220157 - Memory Leak in Refactoring UI
Summary: Memory Leak in Refactoring UI
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Refactoring (show other bugs)
Version: 7.3
Hardware: PC Mac OS X
: P2 normal (vote)
Assignee: Jan Becicka
URL: http://netbeans.org/projects/profiler...
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2012-10-16 09:02 UTC by Jan Becicka
Modified: 2013-01-21 12:16 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Quick patch (1.17 KB, patch)
2012-10-17 08:51 UTC, Tomas Hurka 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Becicka 2012-10-16 09:02:40 UTC 
...through progress bar. Mac OS X specific. Maybe specific to 1.6 b31.
Comment 1 Tomas Hurka 2012-10-16 13:21:16 UTC 
Heap dump is available at <http://netbeans.org/projects/profiler/downloads/download/Heapdumps/headump-220157.zip>
Comment 2 Tomas Hurka 2012-10-16 17:51:08 UTC 
The problem is that ParametersPanel.stop() is not invoked. The sequence of events is:
1) ParametersPanel is added as progress listener via addProgressListener
2) ParametersPanel.start() is invoked
3) ParametersPanel is removed as progress listener via removeProgressListener
4) ParametersPanel.stop() is not invoked because of 3).

The problem is probably caused by asynchronous invocation of Refactoring.prepare(), which fires progressListenerStart - see 2).
Comment 3 Tomas Hurka 2012-10-17 08:51:56 UTC 
Created attachment 126056 [details]
Quick patch

I am attaching quick patch, which solves the memory leak. It should be reviewed thoroughly.
Comment 4 Jan Becicka 2012-10-18 13:20:33 UTC 
Thanks, Tomas, for help.

changeset   : 235644:ca7df9a3f5ba