This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 220627 - Find in files hits maximum results in ignored files
Summary: Find in files hits maximum results in ignored files
Status: RESOLVED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Search (show other bugs)
Version: 7.2
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: Jaroslav Havlin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-23 08:23 UTC by ErikRoelofs
Modified: 2012-10-25 10:54 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ErikRoelofs 2012-10-23 08:23:33 UTC 
When you search for a term in your entire source with the Ignore List filter on, results in the 'ignore' list aren't listed. However, they still count towards the maximum number of possible hits.

This means that if you have a file in your ignore list that contains lots of hits for the search term, the search will abort when it hits that file, even though only a handful of results are listed.

You would expect that ignored files aren't searched at all, and don't count against the maximum matches.

Right now I have a log file with thousands of entries of the term I'm looking for, and this is causing my search to abort, even though the log file isn't listed in the results because it is being ignored.
Comment 1 Jaroslav Havlin 2012-10-23 08:42:43 UTC 
Ignore List is applied before checking content of files.
Can you please ensure that the Ignore List is set correctly?

Please note that the file that contains lots of hits (over limit) is not shown in the search results, because the results wouldn't be complete and it could be confusing.
So it seems that the file is not ignored. Maybe the pattern is not valid.
Can you please check it? Thanks.
Comment 2 ErikRoelofs 2012-10-23 09:05:18 UTC 
Confirmed. There was a second log file generating more hits that was indeed not listed in the results, so I hadn't added it to the filter. It's working properly now. It is indeed confusing (both when showing and not showing the file, I guess).
Comment 3 Jaroslav Havlin 2012-10-23 11:32:04 UTC 
I don't think that your bug report is invalid.
If the top-level node has text "Found 5 000 matches in 1 files so far...", you should see the file and first 5000 matches in it.

If you see at which file the limit was reached, you can easily realize that your Ignore List needs to be modified. So this is probably less confusing than not showing the file at all.

Fixed in http://hg.netbeans.org/core-main/rev/1786e1bff617

Thank you for your help.
Comment 4 Quality Engineering 2012-10-25 10:54:29 UTC 
Integrated into 'main-golden', will be available in build *201210250921* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/1786e1bff617
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #220627: Find in files hits maximum results in ignored files