This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 222432 - NullPointerException: No iterator for MultiFileObject@573814ce[Templates/Project/Samples/HTML5/EaselDemo]
Summary: NullPointerException: No iterator for MultiFileObject@573814ce[Templates/Proj...
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Samples (show other bugs)
Version: 7.3
Hardware: All All
: P2 normal (vote)
Assignee: Martin Janicek
URL:
Keywords:
: 222318 222523 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-11-19 21:38 UTC by Petr Jiricka
Modified: 2012-11-22 02:44 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter: 195397

Attachments
stacktrace (3.80 KB, text/plain)
2012-11-19 21:38 UTC, Petr Jiricka 		Details
Patch with possible solution (7.67 KB, patch)
2012-11-20 15:44 UTC, Martin Janicek 		Details | Diff
Updated patch (8.06 KB, patch)
2012-11-21 10:20 UTC, Martin Janicek 		Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Jiricka 2012-11-19 21:38:11 UTC 
This issue was reported manually by pjiricka.
It already has 1 duplicates 


Build: NetBeans IDE Dev (Build web-main-9256-on-20121119)
VM: Java HotSpot(TM) 64-Bit Server VM, 23.6-b04, Java(TM) SE Runtime Environment, 1.7.0_10-ea-b15
OS: Mac OS X

User Comments:
pjiricka: New HTML5 Sample wizard.




Stacktrace: 
java.lang.NullPointerException: No iterator for MultiFileObject@573814ce[Templates/Project/Samples/HTML5/EaselDemo]
   at org.netbeans.modules.ide.ergonomics.newproject.DescriptionStep.waitForDelegateWizard(DescriptionStep.java:293)
   at org.netbeans.modules.ide.ergonomics.newproject.DescriptionStep.access$000(DescriptionStep.java:91)
   at org.netbeans.modules.ide.ergonomics.newproject.DescriptionStep$1.call(DescriptionStep.java:114)
   at org.netbeans.modules.ide.ergonomics.newproject.DescriptionStep$1.call(DescriptionStep.java:110)
   at org.netbeans.modules.ide.ergonomics.fod.ConfigurationPanel$2$1.run(ConfigurationPanel.java:213)
   at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
Comment 1 Petr Jiricka 2012-11-19 21:38:12 UTC 
Created attachment 128101 [details]
stacktrace
Comment 2 Petr Jiricka 2012-11-19 21:41:23 UTC 
Looks like bug 221083 is back. Martin, can you please investigate? Thanks.
Comment 3 Martin Janicek 2012-11-20 08:41:46 UTC 
Well reading the discussion within the issue 221083, the original solution can't be used anymore. I've deleted the useless HTML5 Project --> HTML5 Samples dependency to be able to add HTML5 Samples --> HTML5 Project dependency (which makes logically much more sense and it's essence to the new samples implementation).
As a conclusion, this is almost certainly a regression caused by my changeset (web-main #220746803808), but it I don't think I can workarround this in an easy way (of course it's possible but it would mean rewriting quite a lot of code even in HTML5 Project which I don't think we should do at this stage of development cycle)

Is there another way how to make HTML5 Samples visible in webcommon cluster?
Comment 4 Martin Janicek 2012-11-20 15:06:02 UTC 
The problem is that in opposite to Groovy/PHP etc. we don't have a HTML5 Kit for activation web client modules. Ergonomics are activating the whole HTML support just through the web.clientproject module which does not look like a good solution anymore.

I'm going to create new HTML5 Kit containing all required dependencies. That should fix the problem, I hope..
Comment 5 Petr Jiricka 2012-11-20 15:34:55 UTC 
Sounds good. I believe you will also need to modify ide.ergonomics/webcommon.properties and maybe other things in the ergonomics area - please talk you Jarda about any required changes - thanks!
Comment 6 Martin Janicek 2012-11-20 15:44:59 UTC 
Created attachment 128145 [details]
Patch with possible solution

I'm attaching the patch with a possible solution. It creates a new module called HTML5 Kit, which contains the same dependencies as HTML5 project with two exception:

1] I have removed javascript.jstestdriver and libs.jstestdriver because they don't seem to be needed ..there is probably more not-needed dependencies, but I don't know anything about these modules so I would rather let this for someone else

2] I have added new dependency for HTML5 Samples (which fixes original problem)

..in addition I have changed ergonomics moduleName activator (for webcommon) to the newly created html5 kit and updated cluster.properties
Comment 7 Martin Janicek 2012-11-20 15:50:24 UTC 
CCing to David. Could you please review the patch?
Especially the HTML5 Kit dependencies should be narrow to a minimal set. Would be good if you could tell me what is redundant. Thanks ;) (BTW: Not sure who else could be interested in this, so please CC to anyone related)
Comment 8 Martin Janicek 2012-11-20 15:51:04 UTC 
(In reply to comment #5)
> Sounds good. I believe you will also need to modify
> ide.ergonomics/webcommon.properties and maybe other things in the ergonomics
> area - please talk you Jarda about any required changes - thanks!

Ye, I was aware of that. Thanks anyway
Comment 9 David Konecny 2012-11-21 01:59:00 UTC 
Creating HTML5 Kit is a good idea. I thought we will need it sooner or later.

In offline email I sent to you and Tomas I would like to get rid of the exported APIs from web.clientproject module and dependency which web.clientproject.samples has. But regardless of that HTML5 Kit makes sense to me.

Could we add "kit" to the name of the new module - these kit modules are pretty useless and it is good to see from the name that it is a kit. web.clientproject.kit maybe?

Re. dependencies - because web.clientproject was so far the top level module then I would think that just adding web.clientproject and web.clientproject.samples to the kit should do the trick, no?

There are other kits which will need to be updated to point to this new kit - web.kit and php.kit.

And I think "AutoUpdate-Show-In-Client: true" in manifest of web.clientproject will need to be removed and moved to the kit module? PetrJ knows the most about this flag - I always forget to change it and he usually fixes it. :-)

Thanks for doing this Martin!
Comment 10 Tomas Mysik 2012-11-21 05:31:46 UTC 
(In reply to comment #9)
> There are other kits which will need to be updated to point to this new kit -
> web.kit and php.kit.

Yes. I can do that in php.kit, just let me know or feel free to do it.

Thanks.
Comment 11 Martin Janicek 2012-11-21 09:05:30 UTC 
(In reply to comment #9)
> Creating HTML5 Kit is a good idea. I thought we will need it sooner or later.
> 
> In offline email I sent to you and Tomas I would like to get rid of the
> exported APIs from web.clientproject module and dependency which
> web.clientproject.samples has. But regardless of that HTML5 Kit makes sense to
> me.
> 
> Could we add "kit" to the name of the new module - these kit modules are pretty
> useless and it is good to see from the name that it is a kit.
> web.clientproject.kit maybe?

Or maybe web.client.kit (don't like much the strong relation to "project" modules).

> Re. dependencies - because web.clientproject was so far the top level module
> then I would think that just adding web.clientproject and
> web.clientproject.samples to the kit should do the trick, no?

Ye, make sense :) ..I'm going to do that

> There are other kits which will need to be updated to point to this new kit -
> web.kit and php.kit.
> 
> And I think "AutoUpdate-Show-In-Client: true" in manifest of web.clientproject
> will need to be removed and moved to the kit module? PetrJ knows the most about
> this flag - I always forget to change it and he usually fixes it. :-)

Ok, I'm going to do that as well;)

> Thanks for doing this Martin!
Comment 12 Martin Janicek 2012-11-21 09:11:33 UTC 
*** Bug 222318 has been marked as a duplicate of this bug. ***
Comment 13 Martin Janicek 2012-11-21 09:57:36 UTC 
(In reply to comment #9)
> In offline email I sent to you and Tomas I would like to get rid of the
> exported APIs from web.clientproject module and dependency which
> web.clientproject.samples has. 

I have created issue 222525 to track this.
Comment 14 Martin Janicek 2012-11-21 10:20:36 UTC 
Created attachment 128193 [details]
Updated patch

- name of the kit changed to web.client.kit
- kit contain only web.clientproject and web.client.samples dependency
- updated php.kit and web.kit
- AutoUpdate-Show-In-Client: true moved to the web.client.kit
Comment 15 Martin Janicek 2012-11-21 10:24:43 UTC 
If there will be no more objections, I'll push the changes after the lunch :)
Comment 16 Martin Janicek 2012-11-21 15:24:29 UTC 
Fixed in: web-main #2180da6067dc
Few corrections made in: web-main #d8f6fa525cc4
Comment 17 Denis Anisimov 2012-11-21 18:33:37 UTC 
*** Bug 222523 has been marked as a duplicate of this bug. ***
Comment 18 Quality Engineering 2012-11-22 02:44:20 UTC 
Integrated into 'main-golden', will be available in build *201211220002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/2180da6067dc
User: Martin Janicek <mjanicek@netbeans.org>
Log: #222432 - NullPointerException: No iterator for MultiFileObject@573814ce[Templates/Project/Samples/HTML5/EaselDemo]