This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 226341 - Fix warnings from InstalledFileLocatorImpl
Summary: Fix warnings from InstalledFileLocatorImpl
Status: VERIFIED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.4
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: TomasKraus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-19 13:48 UTC by Jiri Skrivanek
Modified: 2013-03-05 09:29 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Skrivanek 2013-02-19 13:48:33 UTC
Please, fix your code to prevent warnings from InstalledFileLocatorImpl.

WARNING [org.netbeans.core.startup.InstalledFileLocatorImpl]: no code name base passed when looking up docs/javaee-doc-api.jar at org.netbeans.modules.glassfish.javaee.JavaEEServerModuleFactory.ensureEclipseLinkSupport(JavaEEServerModuleFactory.java:208)
WARNING [org.netbeans.core.startup.InstalledFileLocatorImpl]: no code name base passed when looking up docs/javaee-doc-api.jar at org.netbeans.modules.glassfish.javaee.JavaEEServerModuleFactory.ensureGlassFishApiSupport(JavaEEServerModuleFactory.java:283)
WARNING [org.netbeans.core.startup.InstalledFileLocatorImpl]: no code name base passed when looking up docs/javaee-doc-api.jar at org.netbeans.modules.glassfish.javaee.Hk2LibraryProvider.setLibraryImplementationContent(Hk2LibraryProvider.java:414)
WARNING [org.netbeans.core.startup.InstalledFileLocatorImpl]: no code name base passed when looking up docs/javaee-doc-api.jar at org.netbeans.modules.glassfish.javaee.Hk2LibraryProvider.setLibraryImplementationContent(Hk2LibraryProvider.java:414)
WARNING [org.netbeans.core.startup.InstalledFileLocatorImpl]: no code name base passed when looking up docs/javaee-doc-api.jar at org.netbeans.modules.glassfish.javaee.JavaEEServerModuleFactory.ensureEclipseLinkSupport(JavaEEServerModuleFactory.java:208)
WARNING [org.netbeans.core.startup.InstalledFileLocatorImpl]: no code name base passed when looking up docs/javaee-doc-api.jar at org.netbeans.modules.glassfish.javaee.JavaEEServerModuleFactory.ensureGlassFishApiSupport(JavaEEServerModuleFactory.java:283)
Comment 1 TomasKraus 2013-02-19 14:21:23 UTC
Those warning seems to be there for very long time. I would better check why they started showing up now.
Comment 2 TomasKraus 2013-02-19 15:09:31 UTC
Anyway, this piece of code is somehow redundant in JavaEEServerModuleFactory. It's verifying things that should come from Hk2LibraryProvider and it's the only place where docs/javaee-doc-api.jar should be located.
Code name base should be "javax" for Java EE API.

I fixed it to contain "javax" as code base. But all those ensure methods should be removed from JavaEEServerModuleFactory code in the future.
Comment 3 TomasKraus 2013-02-19 15:39:21 UTC
I had to make one more change. Looks like code base is related to module owning searched file. Changed to org.netbeans.modules.j2ee.platform and see no warnings now.
Comment 4 TomasKraus 2013-02-19 16:02:20 UTC
Will be in trunk after next merge.
Comment 5 TomasKraus 2013-02-19 16:04:32 UTC
NetBeans web-main:
------------------
changeset:   246001:9d3250784091
branch:      javaee7
user:        Tomas Kraus <TomasKraus@netbeans.org>
summary:     #226341 - Removed warnings from InstalledFileLocatorImpl
Comment 6 Quality Engineering 2013-03-05 01:50:29 UTC
Integrated into 'main-golden', will be available in build *201303042300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/9d3250784091
User: Tomas Kraus <TomasKraus@netbeans.org>
Log: #226341 - Removed warnings from InstalledFileLocatorImpl