This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 228553 - Verifier Output unparsable
Summary: Verifier Output unparsable
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.3
Hardware: PC Windows XP
: P2 normal (vote)
Assignee: TomasKraus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-15 02:41 UTC by bht
Modified: 2013-05-02 14:14 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Verifier log. (3.92 KB, text/plain)
2013-04-25 12:15 UTC, Jiri Skrivanek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bht 2013-04-15 02:41:30 UTC
Prerequisites:

Services window|GlassFish|View Domain Update Center
Install:
- GlassFish Verifier Tool
- GlassFish verifier Localization

How to reproduce:

- Menu|File|New Project|Samples|JavaEE|Servlet Stateless (Java EE 6)|Finish
- Projects Window|Project Node Servlet Stateless|Right click|Verify

Expected result: The project should be verified

Actual result:

Verifier output unparsable
Verifier output (<project location>\ServletStateless\dist\ServletStateless.war.xml) not found.
Comment 1 TomasKraus 2013-04-24 13:24:51 UTC
I'll have a look at this tomorrow.
Comment 2 TomasKraus 2013-04-25 10:55:49 UTC
Product Version         = NetBeans IDE Dev (Build 20130424-e8f6d1089ebb) (#e8f6d1089ebb)
Operating System        = Linux version 2.6.38-8-generic running on amd64
Java; VM; Vendor        = 1.6.0_38; Java HotSpot(TM) 64-Bit Server VM 20.13-b02; Sun Microsystems Inc.
Runtime                 = Java(TM) SE Runtime Environment 1.6.0_38-b05
Java Home               = /usr/java/jdk1.6.0_38/jre
System Locale; Encoding = en_US (nb); UTF-8

verify:
running /users/tomas/WS/gfr3122/glassfish/bin/verifier -ra -d /tmp/ServletStateless/dist /tmp/ServletStateless/dist/ServletStateless.war 
 INFO: Verifying: [ ServletStateless ]
 WARNING: setRuntimeDDPresent method not implemented
 INFO: Verifying: [ ServletStateless ]
 WARNING: setRuntimeDDPresent method not implemented
 INFO: Compiling JSPs in [ ServletStateless ]
 INFO: 
# of Failures : 1
# of Warnings : 0
# of Errors   : 0
 INFO: Look in file "/tmp/ServletStateless/dist/ServletStateless.war.txt" for detailed results.
BUILD SUCCESSFUL (total time: 8 seconds)

I don't see any issue with last 7.3.1 dev build. Please can you try last development build from http://bertram2.netbeans.org:8080/job/web-main-javaee7/ to reproduce this issue?
Comment 3 TomasKraus 2013-04-25 10:57:54 UTC
Adding Jiri Skrivanek into CC list to verify this scenario too to double check it's working in 7.3.1.
Comment 4 Jiri Skrivanek 2013-04-25 12:15:06 UTC
Created attachment 133795 [details]
Verifier log.

For me it is reproducible with GlassFish 4 (build 85).

Product Version: NetBeans IDE Dev (Build web-main-javaee7-259-on-20130425)
Java: 1.7.0_17; Java HotSpot(TM) 64-Bit Server VM 23.7-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_17-b02
System: Windows 7 version 6.1 running on amd64; Cp1250; en_US (nb
Comment 5 TomasKraus 2013-04-25 13:09:01 UTC
OK, That means something has changed in GF 4 that is not recognized by current code. Unfortunately I have some issues installing Verifier Tool for GF4 now. :(
Comment 6 TomasKraus 2013-04-25 15:16:50 UTC
This issue seems to be a huge problem in current NetBeans.

1) GF 4 verifier tool was never released and made public so you are probably using an old one and no one knows what will happen with the new one.
2) GF 4 verifier tool was built with JDK 7 and current NetBeans code is unable to start it when default platform is JDK 6.

I got this new GF 4 verifier tool today and I made my private update server with real update tool for GF 4 to test it.
Unfortunately I ended up with (2) JDK 6 issue and first thing to fix here is to change the code responsible for starting the verifier. It should use JDK from GlassFish instance properties as server startup code does.

After that I have to check and fix output processing code.

glassfish.eecommon/src/org/netbeans/modules/glassfish/eecommon/api/VerifierSupport.java is current code responsible for verifier support.
I will move startup code to GF Tooling Library where this is already implemented for server.
Comment 7 TomasKraus 2013-04-26 14:44:38 UTC
GlassFish Tooling Library:
--------------------------
changeset:   262:28840050b2de
branch:      0.3-b036
summary:     Added verifier classpath jars support

changeset:   498:cd983a7a07d6
summary:     Added verifier classpath jars support

This is part of future verifier support in the library. There was not enough time to move whole process startup code here. It's in TODO for trunk after 7.3.1 release.

NetBeans web-main:
------------------
changeset:   251388:f69aeecd3cdc
branch:      javaee7
summary:     #228553 - Verifier startup code changed to use JDK
             registered in GlassFish properties

I had to change whole startup code to not use verifier script anymore.
It will build /some/java -cp <verifier classpath> <cerifier main class> <arguments> itself using GlassFishInstance object (JDK and server installation directory stored there).

For 7.3.1 I just modified existing cerifier support code in glassfish.eecommon and glassfish.javaee modules. Unfortunately there are too many dependencies on glassfish.common so it should be cleaned up later in trunk.
Startup code should be moved to GlassFish Tooling Library to make it available also for Eclipse.

Will test and push on Monday.
Comment 8 TomasKraus 2013-04-29 11:30:55 UTC
Thanks to Jiri we tested that also Verifier output unparsable is fixed now.
I'm closing this bug.
Comment 9 Quality Engineering 2013-05-02 14:14:21 UTC
Integrated into 'main-golden', will be available in build *201305021042* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/f69aeecd3cdc
User: Tomas Kraus <TomasKraus@netbeans.org>
Log: #228553 - Verifier startup code changed to use JDK registered in GlassFish properties