This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 228624 - JMS connection factory resource creation for GlassFish 4 needs fixing
Summary: JMS connection factory resource creation for GlassFish 4 needs fixing
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: GlassFish (show other bugs)
Version: 7.3.1
Hardware: PC Windows 7
: P3 normal (vote)
Assignee: TomasKraus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-16 14:21 UTC by chaase3
Modified: 2013-06-18 08:28 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description chaase3 2013-04-16 14:21:48 UTC
Using the latest promoted build of GF 4 and the 4/9 dev build of NB 7.3.1, I do the following:
 right-click a Java EE EE Maven project and select New->Other
 select GlassFish, then JMS Resource
 type a JNDI name for a connection factory and select javax.jms.ConnectionFactory for the type

A src/main/setup/glassfish-resources.xml file is created.

As has always been the case with previous GlassFish resource creation, the resulting connector connection factory and connector connection pool both have the same name. 

In GlassFish 4, however, they are required to have different names. See http://java.net/jira/browse/GLASSFISH-15104 for details.

If you use "asadmin create-jms-resource" to create a connection factory, the command adds the suffix "-Connection-Pool" to the name of the corresponding connection pool.

C:\tut-ws\trunk\examples\jms>asadmin create-jms-resource --restype javax.jms.Con
nectionFactory jms/MyConnFac
Connector resource jms/MyConnFac created.
Command create-jms-resource executed successfully.

C:\tut-ws\trunk\examples\jms>asadmin list-jms-resources
jms/__defaultConnectionFactory
jms/MyConnFac
Command list-jms-resources executed successfully.

C:\tut-ws\trunk\examples\jms>asadmin list-connector-resources
jms/__defaultConnectionFactory
jms/MyConnFac
Command list-connector-resources executed successfully.

C:\tut-ws\trunk\examples\jms>asadmin list-connector-connection-pools
CLI031: Warning: Option "target" is obsolete and will be ignored.
CLI031: Warning: Option "target" is obsolete and will be ignored.
jms/__defaultConnectionFactory-Connection-Pool
jms/MyConnFac-Connection-Pool
Command list-connector-connection-pools executed successfully.

I am not sure what NetBeans is doing under the covers, but it needs to reproduce this process.

I can check this week's NB build and see if this has been fixed, but since there is currently no bug for it that I can find, I think I had better put this in now.

Product Version: NetBeans IDE Dev (Build 201304092301)
Updates: Updates available
Java: 1.7.0_17; Java HotSpot(TM) 64-Bit Server VM 23.7-b01
Runtime: Java(TM) SE Runtime Environment 1.7.0_17-b02
System: Windows 7 version 6.1 running on amd64; Cp1252; en_US (nb)
Comment 1 TomasKraus 2013-04-24 13:23:00 UTC
Connector connection pool is now generated with "-Connection-Pool" suffix to follow asadmin create-jms-resource behavior.

Checked into web-main:
----------------------
changeset:   251279:1c96f6386cef
branch:      javaee7
summary:     #228624 - JMS connection factory resource creation
             for GlassFish 4 fixed
Comment 2 Quality Engineering 2013-04-26 02:45:26 UTC
Integrated into 'main-golden', will be available in build *201304252301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/1c96f6386cef
User: Tomas Kraus <TomasKraus@netbeans.org>
Log: #228624 - JMS connection factory resource creation for GlassFish 4 fixed
Comment 3 fyamada 2013-06-17 16:47:41 UTC
I had a related issue with the "-Connection-Pool" sufix when migrating from NB 7.2 with GF 3.1.2 to NB 7.3.1 with GF 4. Because the glassfish-resources.xml had the factory and pool with the same name the resources were created wrongly when the application was deployed using NB 7.3.1. 

The "factoryName" resource and the "factoryName-Connection-Pool" pool resource where created both inside the Connector Connection Pool category and nothing in the Connector Resource.

Because I was using the admin gui (GF web admin module), I could not spot the issue right away since it does not show the resource pools. When I tryied to create a new connection factory using the GF GUI I was getting resource with same name already created error.

This will become an issue when people start to migrate from GF3.1.2 to GF4 with old glassfish-resources.xml files.

It would be nice if NB identify and correct this issue seamlessly while deploying the application with old style glassfish-resources.xml onto GF4 server.
Comment 4 TomasKraus 2013-06-17 17:22:31 UTC
Yes, your note is a good idea. Unfortunately 7.3.1 is out and I'm not sure if there is a chance to get update for it in near future.