This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229386 - Some properties does not make sense for PhoneGap browser
Summary: Some properties does not make sense for PhoneGap browser
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Project (show other bugs)
Version: 7.4
Hardware: All All
: P3 normal (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on:
Blocks: 229388
  Show dependency tree
 
Reported: 2013-05-06 07:59 UTC by Jan Becicka
Modified: 2013-07-03 02:29 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Becicka 2013-05-06 07:59:37 UTC 
Web Server and Web Root properties does not make sense for PhoneGap "browsers"
Comment 1 David Konecny 2013-05-06 20:30:50 UTC 
I was thinking about adding some SPI to control that.
Comment 2 David Konecny 2013-06-30 22:43:44 UTC 
Tomas could you look into this issue. I think the fix could be as simple as enhancing org.netbeans.modules.web.clientproject.spi.platform.ProjectConfigurationCustomizer with some ability to express that some default UI elements in HTML's Run panel should be hidden.
Comment 3 Tomas Mysik 2013-07-01 08:49:23 UTC 
Please notice that I have no idea what the plans for using ProjectConfigurationCustomizer are - so feel free to suggest better names and/or better solution.

What about just this simple change:

public interface ProjectConfigurationCustomizer {
    JPanel createPanel();

    EnumSet<HiddenProperties> getHiddenProperties();

    enum HiddenProperties {
        WEB_SERVER,
        WEB_ROOT,
    }

}

It should work and should be ready for future changes. What do you think, guys?

Thanks.
Comment 4 David Konecny 2013-07-01 21:57:14 UTC 
I think this is pretty good. Thx.
Comment 5 Tomas Mysik 2013-07-02 09:00:05 UTC 
Done but:
- Honzo please verify PhoneGap "browser" - IMHO it does not provide ProjectConfigurationCustomizer and I am not sure if it is expected or not;
- Davide, if there is no ProjectConfigurationCustomizer, the web server related fields are shown.

Also, I have found out that just one property is needed (only WEB_SERVER, Web Root depends on it).

Thanks.

http://hg.netbeans.org/web-main/rev/6389e7e117fe
Comment 6 Quality Engineering 2013-07-03 02:29:04 UTC 
Integrated into 'main-silver', will be available in build *201307022300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/6389e7e117fe
User: Tomas Mysik <tmysik@netbeans.org>
Log: #229386 - Some properties does not make sense for PhoneGap browser