This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 231332 - JavaEE hints are unmanageable, they cannot be turned on/off, changed
Summary: JavaEE hints are unmanageable, they cannot be turned on/off, changed
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: EJB (show other bugs)
Version: 7.3.1
Hardware: All All
: P2 normal (vote)
Assignee: Martin Fousek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-17 06:45 UTC by Martin Fousek
Modified: 2013-06-28 02:18 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Fousek 2013-06-17 06:45:56 UTC
According to the summary. We have in the JavaEE area about 20 hints which can't be managed in the Options. When any hint contains an issue, there is no way how to workaround the issue. Also users are not able to setup their custom error levels etc.
Comment 1 Martin Fousek 2013-06-25 14:39:06 UTC
Created helper method for EJBProblemContext creation which should be usable by most of hints. It should be possible to run ejbverification hints using the EJBProblemContext, without hints rewrite.

First annotation has been adapted for the new Hints API: AnnotationPostContruct

web-main #3791e3c42937
Comment 2 Sergey Petrov 2013-06-25 15:07:31 UTC
I may need to implement smth similar in jpa area
Comment 3 Quality Engineering 2013-06-26 02:24:52 UTC
Integrated into 'main-golden', will be available in build *201306252301* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/3791e3c42937
User: Martin Fousek <marfous@netbeans.org>
Log: #231332 - JavaEE hints are unmanageable, they cannot be turned on/off, changed - AnnotationPostConstruct
Comment 4 Martin Fousek 2013-06-26 04:28:00 UTC
(In reply to comment #2)
> I may need to implement smth similar in jpa area

Right, I already thought about this and asked at the beginning jlahoda whether there would be a chance do get into JavaEE node in options another level of subcategories. If you would be interested in this too, I'll ask him for implementing this - I'll keep you informed.
Comment 5 Martin Fousek 2013-06-26 12:54:34 UTC
Ok after discussion with Honza, I created an issue for creation of hints subcategories: bug #231839

The only difficulties which I'm facing now is the test environment setup.
Comment 6 Martin Fousek 2013-06-27 05:36:05 UTC
Rewrote of the AsynchronousMethodInvocation hint and finally established tests infrastructure: web-main #8980f1eb3a5a
Comment 7 Martin Fousek 2013-06-27 14:31:33 UTC
Ok, all hints are switched to the jlahoda's Hints API. There would be possible to spent much more time on it since the logic of previous hints and the new API is pretty different, but I gave it at least the necessary work. Additionally to check that the functionality remains, I created tests against all of hints.

Hint updates:
web-main #b2bf57cdb625
web-main #90d67d3cda16
web-main #bff338409889
web-main #bbcbedda5888
web-main #7f287aa1de11
web-main #9585652a5133
web-main #66d776f3618e
web-main #3f24d40705b4
web-main #9d9a08b30bec
web-main #8fd9453cb157
web-main #058a32e87f5b
web-main #eb95f896fdc5
web-main #9ad7b04e68e3

Final clean-up:
web-main #7f3e5da695b1

And additional fix of node IDs:
web-main #cc2b06396701

Sergey if you are going to rewrite your hints too, I would wait at least a week whether there will appear any serious issue. ;)
Comment 8 Quality Engineering 2013-06-28 02:18:01 UTC
Integrated into 'main-silver', will be available in build *201306272300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/8980f1eb3a5a
User: Martin Fousek <marfous@netbeans.org>
Log: #231332 - JavaEE hints are unmanageable, they cannot be turned on/off, changed:AsynchronousMethodInvocation + tests