This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 237717 - Patch for: Dark Theme: Findbugs "Inspect" explanations hard to read (black on dark blue)
Summary: Patch for: Dark Theme: Findbugs "Inspect" explanations hard to read (black on...
Status: RESOLVED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: FindBugs (show other bugs)
Version: 7.4
Hardware: PC All
: P3 normal (vote)
Assignee: Petr Cyhelsky
URL:
Keywords: PATCH_AVAILABLE
Depends on:
Blocks:
 
Reported: 2013-10-28 13:47 UTC by twolf2919
Modified: 2013-10-29 11:29 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
The Inspect tab, showing unreadable explanations. (86.80 KB, image/png)
2013-10-28 13:47 UTC, twolf2919 		Details
Proposed patch (1.95 KB, patch)
2013-10-28 20:24 UTC, markiewb 		Details | Diff
Patch in action (86.53 KB, image/png)
2013-10-28 20:24 UTC, markiewb 		Details
Patch in action - resubmitted (86.53 KB, image/png)
2013-10-28 20:30 UTC, markiewb 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description twolf2919 2013-10-28 13:47:23 UTC 
Created attachment 141604 [details]
The Inspect tab, showing unreadable explanations.

When you do a Source->Inspect the results are displayed in a two-panel tab.  The left panel shows in a tree all the problems found.  The right side gives an explanation of the problem for the item selected in the tree.  This explanation is very difficult to read because the foreground color of the font wasn't changed to WHITE in the dark theme, where the background color is now a dark blue.
Comment 1 markiewb 2013-10-28 19:40:27 UTC 
Related to a already fixed bug https://netbeans.org/bugzilla/show_bug.cgi?id=234038
Comment 2 markiewb 2013-10-28 20:24:14 UTC 
Created attachment 141613 [details]
Proposed patch

I like to propose a patch to solve this issue. Please review and commit. Thank you.
Comment 3 markiewb 2013-10-28 20:24:54 UTC 
Created attachment 141614 [details]
Patch in action
Comment 4 markiewb 2013-10-28 20:30:09 UTC 
Created attachment 141615 [details]
Patch in action - resubmitted
Comment 5 Petr Cyhelsky 2013-10-29 11:29:57 UTC 
Thank you for the patch. Fixed in
http://hg.netbeans.org/jet-main/rev/0e2aaf762848