This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
THe image editor's toolbar should be polished to better fit into NetBeans UI
I agree. so, I need some UI spec. for it.
Created Task for UI spec (24628) and made this bug depend on it, changing back to image module, since this is still an issue for image. Changing target milestone to 4.0 since this cannot be done in 3.4.
Toolbar doesn't use rollover effec. WinLnf, that doesn't use it by default looks ugly, ugly, ugly!
Created attachment 13012 [details] Adds rollover effect to toolbar
One more issue on WinLnf: Separators paint vertical line. Current implementation of the toolbar sets the size of separators to 2x2 pixes - resulting in centered points between buttons. To fix this, simply set height to 0 pixels. Not sure about this one, as it is a LnF a specific hack (which doesn't alter at least metal look and feel behaviour. BTW: I bet this is the same reason why we have such points in the main toolbars just after the dragger grid. Tim, is there another way to fix this - maybe by changing WinLnF's separator ui class?
Created attachment 13015 [details] sets height to 0 and removes some unneeded separators
For Aqua, I've implemented a NetBeans-specific toolbar UI for the main window - you would be able to fetch it via UIManager.get(). For the others, it is the existing legacy code in openide/loaders/org/openide/awt/Toolbar.java - this needs cleaning up at some point. So unfortunately, for now I don't have any clean solution to offer you - you could have a look at the main window toolbar class, but it's not cleanly implemented and is pretty specific to the main window toolbars. Sometime post 3.6 I'll probably migrate our toolbar ui mods to some standard UI delegates that core will install. That's pretty low priority, as the existing code works - but it may be done if we get to the declaritive actions stuff for 4.0. We also need to fix the whole way menus are done to make them work properly on OS-X - since both of these things touch the actions infrastructure pretty deeply, some toolbar stuff could get rolled into that. Suggestion: at least for the time being, just make the toolbar a JPanel. Not perfect, but livable; you could give it a toolbar-esque border if you want. Or at least set the property so that it can't be floated - this causes problems in the window system.
I am not allowed to do such changes after UI freeze => 4.0
Common, editor ui is still unfinished and window system look changes on a daily basis. This one has to get fixed - at least the rollover effect!
I think we will all forgive you if you call setFloating(false).
Does the Image module refers to the one when I open my GIF file in the IDE? If so I think the buttons in that toolbar has the correct behaviour these days - well at least on Windows XP (NB5 build 200511281900).
Obsolete milestone, please reevaluate
Good lord, we've had a patch for this since 2004 and this issue was opened in 2002. Anyway, main issues at this point: - The buttons should not be focusable - They should have rollover set to true - The toolbar should not be floatable (looks like someone at least already did that)
I have fixed these issues: - the buttons should not be focusable - they should have roll-over set to true Modified file: image/src/org/netbeans/modules/image/ImageViewer.java Changeset Id: 39d5a89c6a73 (http://hg.netbeans.org/main/rev/39d5a89c6a73)
Integrated into 'main-golden', available in NB_Trunk_Production #352 build Changeset: http://hg.netbeans.org/main/rev/39d5a89c6a73 User: Marian Petras <mpetras@netbeans.org> Log: partially fixed bug #24598 - "The Image module UI does not adhere to NB UI guidelines"
Assigning issues from Michael to Andrey.
This issue definitely out of scope for 6.7. Transform to Task for next release