This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 24598 - The Image module UI does not adhere to NB UI guidelines
Summary: The Image module UI does not adhere to NB UI guidelines
Status: NEW
Alias: None
Product: utilities
Classification: Unclassified
Component: Image (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P3 blocker (vote)
Assignee: Jan Peska
Keywords: UI
Depends on: 24628
  Show dependency tree
Reported: 2002-06-10 16:51 UTC by iformanek
Modified: 2011-09-01 15:53 UTC (History)
3 users (show)

See Also:
Issue Type: TASK
Exception Reporter:

Adds rollover effect to toolbar (875 bytes, patch)
2004-01-21 20:41 UTC, _ mruflin
Details | Diff
sets height to 0 and removes some unneeded separators (2.39 KB, patch)
2004-01-21 21:59 UTC, _ mruflin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description iformanek 2002-06-10 16:51:07 UTC
THe image editor's toolbar should be polished to better 
fit into NetBeans UI
Comment 1 Jan Jancura 2002-06-11 10:02:17 UTC
I agree.
so, I need some UI spec. for it.
Comment 2 iformanek 2002-06-11 10:28:34 UTC
Created Task for UI spec (24628) and made this bug depend 
on it, changing back to image module, since this is still 
an issue for image. Changing target milestone to 4.0 since 
this cannot be done in 3.4. 
Comment 3 _ mruflin 2004-01-21 20:38:23 UTC
Toolbar doesn't use rollover effec. WinLnf, that doesn't use it by 
default looks ugly, ugly, ugly!
Comment 4 _ mruflin 2004-01-21 20:41:16 UTC
Created attachment 13012 [details]
Adds rollover effect to toolbar
Comment 5 _ mruflin 2004-01-21 21:53:04 UTC
One more issue on WinLnf:
Separators paint vertical line. Current implementation of the toolbar 
sets the size of separators to 2x2 pixes - resulting in centered 
points between buttons. To fix this, simply set height to 0 pixels.

Not sure about this one, as it is a LnF a specific hack (which 
doesn't alter at least metal look and feel behaviour.
BTW: I bet this is the same reason why we have such points in the 
main toolbars just after the dragger grid.

Tim, is there another way to fix this - maybe by changing WinLnF's 
separator ui class? 
Comment 6 _ mruflin 2004-01-21 21:59:44 UTC
Created attachment 13015 [details]
sets height to 0 and removes some unneeded separators
Comment 7 _ tboudreau 2004-01-21 22:15:58 UTC
For Aqua, I've implemented a NetBeans-specific toolbar UI for the main
window - you would be able to fetch it via UIManager.get().  For the
others, it is the existing legacy code in
openide/loaders/org/openide/awt/ - this needs cleaning up
at some point.  So unfortunately, for now I don't have any clean
solution to offer you - you could have a look at the main window
toolbar class, but it's not cleanly implemented and is pretty specific
to the main window toolbars.  

Sometime post 3.6 I'll probably migrate our toolbar ui mods to some
standard UI delegates that core will install.  That's pretty low
priority, as the existing code works - but it may be done if we get to
the declaritive actions stuff for 4.0.  We also need to fix the whole
way menus are done to make them work properly on OS-X - since both of
these things touch the actions infrastructure pretty deeply, some
toolbar stuff could get rolled into that.

Suggestion:  at least for the time being, just make the toolbar a
JPanel.  Not perfect, but livable;  you could give it a toolbar-esque
border if you want.  Or at least set the property so that it can't be
floated - this causes problems in the window system.

Comment 8 Jan Jancura 2004-01-22 09:08:27 UTC
I am not allowed to do such changes after UI freeze => 4.0
Comment 9 _ mruflin 2004-01-22 10:54:34 UTC
Common, editor ui is still unfinished and window system look changes 
on a daily basis. This one has to get fixed - at least the rollover 
Comment 10 _ tboudreau 2004-09-03 16:27:34 UTC
I think we will all forgive you if you call setFloating(false).
Comment 11 _ alexlamsl 2005-12-01 01:39:42 UTC
Does the Image module refers to the one when I open my GIF file in the IDE? If 
so I think the buttons in that toolbar has the correct behaviour these days - 
well at least on Windows XP (NB5 build 200511281900).
Comment 12 Jiri Prox 2007-09-17 20:27:08 UTC
Obsolete milestone, please reevaluate
Comment 13 _ tboudreau 2008-07-01 15:47:39 UTC
Good lord, we've had a patch for this since 2004 and this issue was opened in 2002.  Anyway, main issues at this point:
 - The buttons should not be focusable
 - They should have rollover set to true
 - The toolbar should not be floatable (looks like someone at least already did that)
Comment 14 Marian Petras 2008-07-28 17:18:40 UTC
I have fixed these issues:
- the buttons should not be focusable
- they should have roll-over set to true

Modified file:

Changeset Id:
Comment 15 Quality Engineering 2008-07-29 03:55:46 UTC
Integrated into 'main-golden', available in NB_Trunk_Production #352 build
User: Marian Petras <>
Log: partially fixed bug #24598 - "The Image module UI does not adhere to NB UI guidelines"
Comment 16 Alexei Mokeev 2009-03-05 13:49:47 UTC
Assigning issues from Michael to Andrey.
Comment 17 Alexey Butenko 2009-03-23 10:50:04 UTC
This issue definitely out of scope for 6.7.
Transform to Task for next release