This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 250232 - No way to detect ProjectConvertor project
Summary: No way to detect ProjectConvertor project
Status: VERIFIED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Generic Infrastructure (show other bugs)
Version: 8.1
Hardware: All All
: P2 normal (vote)
Assignee: Tomas Zezula
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks: 250267 250268 253339
  Show dependency tree
 
Reported: 2015-02-05 10:56 UTC by Tomas Mysik
Modified: 2015-07-16 06:12 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Diff file (8.02 KB, patch)
2015-07-15 08:13 UTC, Tomas Zezula
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Mysik 2015-02-05 10:56:46 UTC
Discovered while solving issue #250007.

The problem is that there is no way to detect "pure" ProjectConvertor projects; this is needed e.g. when creating new project with existing sources. Yes, one can easily just directly open such directory but not everyone knowns about it or wants to use it (the New Project wizard allows you configure more properties). So it would be great if there was e.g.

boolean isConvertorProject(Project)

method available somewhere in API support.

Feel free to close this issue if you think that everyone should solve this on his own but please note that such solution will work only in the given NB module or an API - with the marker interface to be found in the project's lookup - must be created for it.

Marking as P2 since this needs to be resolved for the DEV version of NetBeans.

Thanks.
Comment 1 Tomas Zezula 2015-07-15 08:13:37 UTC
Created attachment 154641 [details]
Diff file
Comment 2 Tomas Mysik 2015-07-15 08:20:13 UTC
TM01: ProjectConvertors should be final class IMHO.

The patch seems OK to me (very nice unit test!).

Thanks.
Comment 3 Tomas Zezula 2015-07-15 08:34:04 UTC
TM01: Fixed.
Comment 4 Tomas Zezula 2015-07-15 08:34:18 UTC
Fixed jet-main a37de0bb057c
Comment 5 Quality Engineering 2015-07-16 01:21:41 UTC
Integrated into 'main-silver', will be available in build *201507160001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/a37de0bb057c
User: Tomas Zezula <tzezula@netbeans.org>
Log: #250232:No way to detect ProjectConvertor project
Comment 6 Tomas Mysik 2015-07-16 06:12:04 UTC
Verified, thanks.