This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 255617 - I18N: messages at commit are hardcoded
Summary: I18N: messages at commit are hardcoded
Status: RESOLVED INVALID
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Git (show other bugs)
Version: 8.1
Hardware: All All
: P3 normal (vote)
Assignee: Ondrej Vrabec
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-29 11:15 UTC by Masaki Katakai
Modified: 2015-09-30 02:08 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot on Japanese environment - these are English (36.41 KB, image/jpeg)
2015-09-29 11:15 UTC, Masaki Katakai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2015-09-29 11:15:14 UTC
Created attachment 156464 [details]
screenshot on Japanese environment - these are English

It seems that the following messages are not extracted into Bundle.properties and
these are displayed in English on latest NetBeans 8.1 trunk.

./git/src/org/netbeans/modules/git/ui/commit/CommitAction.java


        @NbBundle.Messages({
            "LBL_CommitAction.askToPersistAuthor.title=Set Repository User",
            "# {0} - author",
            "MSG_CommitAction.askToPersistAuthor=Repository does not have fully specified user yet.\n\n"
                    + "Do you want to set {0} as the default author?"
        })

    @NbBundle.Messages({
        "# {0} - repository folder name",
        "# translation hint - HEAD is a git specific term for last revisition in repository, do not translate this word",
        "MSG_CommitAction.detachedHeadState.warning=HEAD is detached in the repository {0}.\n"
            + "It is recommended to switch to a branch before committing your changes.\n\n"
            + "Do you still want to commit?",
        "# translation hint - HEAD is a git specific term for last revisition in repository, do not translate this word",
        "LBL_CommitAction.detachedHeadState.title=Detached HEAD State"
    })

Please evaluate. If there is no string in Bundle.properties, please extract them to Bundle.properties so that we can translate them.
Comment 1 Ondrej Vrabec 2015-09-29 11:35:43 UTC
Using @NbBundle.Messages is a standard practise in NB development, the annotation generates the messages into a bundle during build, you can happily translate those in org.netbeans.modules.git.ui.commit.Bundle_LANG.properties. Right? Or maybe i am missing something here.
Comment 2 Masaki Katakai 2015-09-30 02:08:11 UTC
(In reply to Ondrej Vrabec from comment #1)
> Using @NbBundle.Messages is a standard practise in NB development, the
> annotation generates the messages into a bundle during build, you can
> happily translate those in
> org.netbeans.modules.git.ui.commit.Bundle_LANG.properties. Right? Or maybe i
> am missing something here.

Oh, thanks. This is my mistake. I checked the source codes in hg repository and noticed there is no such messages.

I checked l10n-kit zip file,

http://smetiste.cz.oracle.com/builds/netbeans/trunk/daily/2015-09-30_00-02-28/zip/ide-l10n-201509300002.zip

which are messages to be translated and generated from build, I confirmed these messages are in it.