This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Petr proposed an interesting change of the FileSet API in order to enable to generalize current filtering to operations like union or intersection. So I would integrate following modifications to realize this enhancement: 1. introduce interface ContentListener + class ContentEvent(extending EventObject) ContentListener contentChanged(ContentEvent) ContentEvent(Content source) 2. Replace Filter class with abstract class Content containing public void addContentListener(ContentListener); public void removeContentListener(ContentListener); public abstract boolean contains(URL); // moved from FileSet protected final void fireContentChanged(ContentEvent) // moved from FileSet 3. FileSet will extend Content remove addPropertyChangeListener, removePropertyChangeListener, fireContentChanged, contains, PROP_CONTENT 4. MutableFileSet replace removeAll(FileSet) with removeAll(Content) 5. FileSets remove filterSet add methods: Content union(Content, Content) Content intersection(Content, Content) The original proposal is accessible at http://projects.netbeans.org/servlets/ReadMsg?msgId=381936&listName=dev
Looks good. Thanks !
Implemented in http://projects.netbeans.org/source/browse/projects/filesets/src/org/netbeans/api/filesets/FileSet.java.diff?r1=1.1.2.3&r2=1.1.2.4 http://projects.netbeans.org/source/browse/projects/filesets/src/org/netbeans/api/filesets/FileSets.java.diff?r1=1.1.2.4&r2=1.1.2.5 http://projects.netbeans.org/source/browse/projects/filesets/src/org/netbeans/api/filesets/MutableFileSet.java.diff?r1=1.1.2.3&r2=1.1.2.4 http://projects.netbeans.org/source/browse/projects/filesets/src/org/netbeans/api/filesets/Content.java.diff?r1=1.1&r2=1.1.2.1 http://projects.netbeans.org/source/browse/projects/filesets/src/org/netbeans/api/filesets/ContentEvent.java.diff?r1=1.1&r2=1.1.2.1 http://projects.netbeans.org/source/browse/projects/filesets/src/org/netbeans/api/filesets/ContentListener.java.diff?r1=1.1&r2=1.1.2.1 Adapted projects/filesets, projects and java modules.
verified