This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 28402 - HardStringWizardPanel UI constructed too early
Summary: HardStringWizardPanel UI constructed too early
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: I18N (show other bugs)
Version: 3.x
Hardware: PC All
: P2 blocker (vote)
Assignee: issues@java
URL:
Keywords: PERFORMANCE
Depends on:
Blocks: 27795 34222
  Show dependency tree
 
Reported: 2002-11-01 16:27 UTC by David Simonek
Modified: 2004-02-23 09:25 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Simonek 2002-11-01 16:27:55 UTC 
WizardDescriptor.Panel implementation
HardStringWizardPanel.Panel provides itself as the
result of getComponent().
This hurts performance and can cause a clash when
Component.isValid() is overridden.
Please use a separate component class, see details
at
http://performance.netbeans.org/howto/dialogs/wizard-panels.html.

Easy to fix, P2 justification - performance is top
priority.
Comment 1 Peter Zavadsky 2002-11-01 16:40:57 UTC 
That's wrong, HardStringWizardPanel.Panel isn't a Component and thus
it doesn't provide itself from getComponent method. 
It is the correct implementation according the isValid-overriding-issue.

Please check it, and close as INVALID in case I'm right.
Comment 2 David Simonek 2002-11-01 17:16:02 UTC 
Yes I was wrong, sorry. getComponent() code is ok, however           
     HardStringWizardPanel is constructed when
HardStringWizardPanel.Panel is constrcuted, which is too early, Panel
is heavyweight due to this.

/** HardString panel component. */
private final HardStringWizardPanel hardStringPanel = new
HardStringWizardPanel();

I'm updating summary field to reflect reality.
Comment 3 _ pkuzel 2002-11-01 17:42:35 UTC 
fixed
Comment 4 David Simonek 2002-11-01 17:50:41 UTC 
*WOW* what a speed :-)
Comment 5 ehucka 2004-02-23 09:25:29 UTC 
Verified.