This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 28405 - several wizard panels hurts performance
Summary: several wizard panels hurts performance
Status: VERIFIED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Ant (show other bugs)
Version: -S1S-
Hardware: PC All
: P2 blocker (vote)
Assignee: David Konecny
URL:
Keywords: PERFORMANCE
: 28412 (view as bug list)
Depends on:
Blocks: 27795
  Show dependency tree
 
Reported: 2002-11-01 16:40 UTC by David Simonek
Modified: 2005-07-15 07:49 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Simonek 2002-11-01 16:40:35 UTC
WizardDescriptor.Panel implementation
IntroPanel provides itself as the result of
getComponent().
This hurts performance and can cause a clash when
Component.isValid() is overridden.
Please use a separate component class, see details
at
http://performance.netbeans.org/howto/dialogs/wizard-panels.html.

Easy to fix, P2 justification - performance is top
priority.
Comment 1 David Simonek 2002-11-04 15:33:56 UTC
Similar situation in:
org\apache\tools\ant\module\wizards\properties\AddPropertiesPanel.java
org\apache\tools\ant\module\wizards\properties\SelectFileNamePanel.java 
Please fix them as well, thanx. 
Comment 2 David Simonek 2002-11-05 15:46:46 UTC
Another shots:
\module\wizards\shortcut\CustomizeScriptPanel.java 
org\apache\tools\ant\module\wizards\shortcut\SelectKeyboardShortcutPanel.java
org\apache\tools\ant\module\wizards\shortcut\SelectTargetPanel.java  
Comment 3 David Konecny 2003-01-13 12:50:33 UTC
And this one:
org\apache\tools\ant\module\wizards\shortcut\SelectFolderPanel.java
Comment 4 David Konecny 2003-01-13 12:51:33 UTC
*** Issue 28412 has been marked as a duplicate of this issue. ***
Comment 5 David Konecny 2003-01-20 11:20:16 UTC
Fixed for all Ant wizards:

Checking in
src/org/apache/tools/ant/module/wizards/properties/AddPropertiesPanel.java;
new revision: 1.6; previous revision: 1.5
Checking in
src/org/apache/tools/ant/module/wizards/properties/PropertiesIterator.java;
new revision: 1.3; previous revision: 1.2
Checking in
src/org/apache/tools/ant/module/wizards/properties/SelectFileNamePanel.java;
new revision: 1.6; previous revision: 1.5
Checking in
src/org/apache/tools/ant/module/wizards/shortcut/CustomizeScriptPanel.java;
new revision: 1.7; previous revision: 1.6
Checking in
src/org/apache/tools/ant/module/wizards/shortcut/IntroPanel.java;
new revision: 1.7; previous revision: 1.6
Checking in
src/org/apache/tools/ant/module/wizards/shortcut/SelectFolderPanel.java;
new revision: 1.8; previous revision: 1.7
Checking in
src/org/apache/tools/ant/module/wizards/shortcut/SelectKeyboardShortcutPanel.java;
new revision: 1.6; previous revision: 1.5
Checking in
src/org/apache/tools/ant/module/wizards/shortcut/SelectTargetPanel.java;
new revision: 1.11; previous revision: 1.10
Checking in
src/org/apache/tools/ant/module/wizards/shortcut/ShortcutIterator.java;
new revision: 1.5; previous revision: 1.4
Comment 6 David Simonek 2003-01-24 13:53:48 UTC
Guys, there was an error in example code in IDESettingsWizardPanel.java.
Please check your fix and repair if you did the same mistake. I'm terribly
sorry, but I'm only a human :-)
Please read details below:

---------------------------------
  Modified:    src/org/netbeans/core/ui IDESettingsWizardPanel.java
  Log:
  fix for incorrect assumption that getComponent
  must be called before readSettings.
  Now they can be called in any order.
  
  Revision  Changes    Path
  1.3       +2 -2      core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java
  
 
http://core.netbeans.org/source/browse/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java.diff?r1=1.2&r2=1.3
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: IDESettingsWizardPanel.java
  ===================================================================
  RCS file: /cvs/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -b -r1.2 -r1.3
  --- IDESettingsWizardPanel.java	2002/12/03 14:10:35	1.2
  +++ IDESettingsWizardPanel.java	2003/01/24 13:45:30	1.3
  @@ -7,7 +7,7 @@
    * http://www.sun.com/
    * 
    * The Original Code is NetBeans. The Initial Developer of the Original
  - * Code is Sun Microsystems, Inc. Portions Copyright 1997-2001 Sun
  + * Code is Sun Microsystems, Inc. Portions Copyright 1997-2003 Sun
    * Microsystems, Inc. All Rights Reserved.
    */
   
  @@ -42,7 +42,7 @@
       */
       public void readSettings (Object settings) {
           if (settings instanceof WizardDescriptor) {
  -            panelUI.initFromSettings((WizardDescriptor)settings);
  +            getPanelUI().initFromSettings((WizardDescriptor)settings);
           }
       }
   
Comment 7 Marian Mirilovic 2005-07-15 07:49:54 UTC
closed