This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 28411 - ConnectionPanel1.java hurts performance
Summary: ConnectionPanel1.java hurts performance
Status: VERIFIED FIXED
Alias: None
Product: guibuilder
Classification: Unclassified
Component: Code (show other bugs)
Version: 3.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@guibuilder
URL:
Keywords: PERFORMANCE
Depends on:
Blocks: 27795 34218
  Show dependency tree
 
Reported: 2002-11-01 17:45 UTC by David Simonek
Modified: 2005-07-11 12:50 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Simonek 2002-11-01 17:45:24 UTC
WizardDescriptor.Panel implementation
org\netbeans\modules\form\ConnectionPanel1.java
provides itself as the result of getComponent().
This hurts performance and can cause a clash when
Component.isValid() is overridden.
Please use a separate component class, see details
at
http://performance.netbeans.org/howto/dialogs/wizard-panels.html.

Easy to fix, P2 justification - performance is top
priority. Please look for similar panels in your
module and try to fix them as well. Thanks!
Comment 1 David Simonek 2002-11-05 15:40:04 UTC
Same story:
org\netbeans\modules\form\ConnectionPanel2.java 
org\netbeans\modules\form\ConnectionPanel3.java 
Comment 2 Tomas Pavek 2003-01-21 18:25:30 UTC
Fixed.
Comment 3 David Simonek 2003-01-24 13:53:45 UTC
Guys, there was an error in example code in IDESettingsWizardPanel.java.
Please check your fix and repair if you did the same mistake. I'm terribly
sorry, but I'm only a human :-)
Please read details below:

---------------------------------
  Modified:    src/org/netbeans/core/ui IDESettingsWizardPanel.java
  Log:
  fix for incorrect assumption that getComponent
  must be called before readSettings.
  Now they can be called in any order.
  
  Revision  Changes    Path
  1.3       +2 -2      core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java
  
 
http://core.netbeans.org/source/browse/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java.diff?r1=1.2&r2=1.3
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: IDESettingsWizardPanel.java
  ===================================================================
  RCS file: /cvs/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -b -r1.2 -r1.3
  --- IDESettingsWizardPanel.java	2002/12/03 14:10:35	1.2
  +++ IDESettingsWizardPanel.java	2003/01/24 13:45:30	1.3
  @@ -7,7 +7,7 @@
    * http://www.sun.com/
    * 
    * The Original Code is NetBeans. The Initial Developer of the Original
  - * Code is Sun Microsystems, Inc. Portions Copyright 1997-2001 Sun
  + * Code is Sun Microsystems, Inc. Portions Copyright 1997-2003 Sun
    * Microsystems, Inc. All Rights Reserved.
    */
   
  @@ -42,7 +42,7 @@
       */
       public void readSettings (Object settings) {
           if (settings instanceof WizardDescriptor) {
  -            panelUI.initFromSettings((WizardDescriptor)settings);
  +            getPanelUI().initFromSettings((WizardDescriptor)settings);
           }
       }
   
Comment 4 Tomas Pavek 2003-01-24 14:41:07 UTC
Not using readSettings method, so no problem in this case.
Comment 5 Marek Grummich 2005-07-11 12:50:09 UTC
Verified