This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 29216 - Remove patch for NFT action
Summary: Remove patch for NFT action
Status: CLOSED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Generic Infrastructure (show other bugs)
Version: -S1S-
Hardware: PC Linux
: P2 blocker (vote)
Assignee: Vitezslav Stejskal
URL:
Keywords:
: 29217 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-12-02 16:33 UTC by David Kaspar
Modified: 2003-11-25 14:23 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Exceptions (3.01 KB, text/plain)
2002-12-02 16:36 UTC, David Kaspar
Details
another exception thrown when creating new jar from template (1.92 KB, text/plain)
2002-12-03 09:48 UTC, Milan Kubec
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Kaspar 2002-12-02 16:33:21 UTC
How to reproduce:
1) Do "New..." popup menu action on
"Projects|Sample Project|Output" node
2) In the Wizard select NewJar node and press Next
3) Select "<user_dir>/samples/out" directory and
press Finish
4) ERROR - Exception dialog is shown - see
attachment for exceptions
Comment 1 David Kaspar 2002-12-02 16:36:04 UTC
Created attachment 8135 [details]
Exceptions
Comment 2 David Konecny 2002-12-03 09:25:24 UTC
If you cannot create JAR from template then the problem is most
probably in Jar packager and not in projects. Moving to Ondra for
evaluation.
Comment 3 Milan Kubec 2002-12-03 09:48:40 UTC
Created attachment 8139 [details]
another exception thrown when creating new jar from template
Comment 4 Ondrej Rypacek 2002-12-03 10:13:23 UTC
The behaviour of projects changed, so I have to change jarpackager
too. I'll write a custom WizardIterator .
Comment 5 Vitezslav Stejskal 2002-12-03 10:29:36 UTC
Don't panic, it seems that this problem has to do with change in
NewTemplateAction introduced by pnejedly one or two days ago. This
action doesn't read the target folder from the wizard supplied by the
node where it is invoked. I am not sure whether the problem is in our
nodes or in the action. But it's not in jarpackager since it doesn't
work for java class templates too. Let me investigate it a bit more.
Comment 6 Ondrej Rypacek 2002-12-03 10:57:54 UTC
Anyway, I made the template . It is not very foolproof but at least it
is possible to create the jar build target. It's in CVS.
Comment 7 Vitezslav Stejskal 2002-12-03 11:34:40 UTC
This problem is caused by NewTemplateAction.java, revision 1.66. This
action used to display list of templates as a submenu and called
TemplateWizard.instantiate(template,targetFolder) method which
displayed target chooser panel only when targetFolder was null. If
targetFolder was specified it displayed only simple panel allowing to
enter the name of new object. Now this action always calls
TemplateWizard.instantiate() which always shows the target chooser
panel and ignores supplied target folder. This is regression -> P1.

Also consider Nodes which return instance of TemplateWizard.Cookie
with pre-set templatesFolder and instance of DataFolder from their
Node.getCookie methods. I am not sure if such Nodes are correctly
implemented (perhaps they should have set the targetFolder on the
TemplateWizard instance too), but they used to work.

For projects people: I have rolled back changes of 1.66 revision and
put original version of NewTemplateAction to openide-patches bundled
with projects/ide module. The action works as before. This is
temporary solution.
Comment 8 Petr Nejedly 2002-12-09 15:13:37 UTC
The problem was worked around in projects branch and doesn't cause
any harm in trunk -> decreasing priority.
Comment 9 Vitezslav Stejskal 2002-12-10 00:59:35 UTC
*** Issue 29217 has been marked as a duplicate of this issue. ***
Comment 10 Jaromir Uhrik 2003-01-06 11:18:51 UTC
Version changed: 4.0 dev -> S1S 4.2
Comment 11 Petr Nejedly 2003-01-29 14:04:51 UTC
It should be fixed now on the trunk by the reimplementation of the
NTAction. Vito, could you please verify whether the new impl works
OK in the projects branch and integrate the new version
back to the projects branch?
Comment 12 Vitezslav Stejskal 2003-01-29 14:35:14 UTC
OK, will do, thanks.
Comment 13 Vitezslav Stejskal 2003-01-31 11:41:45 UTC
It seems that trunk version of NFT action works fine in new projects.
I removed our patch so that new projects will use trunk version again.
Comment 14 Jan Becicka 2003-08-21 15:29:21 UTC
Verified
Comment 15 Jan Becicka 2003-11-25 14:23:10 UTC
As described in
http://www.netbeans.org/servlets/ReadMsg?msgId=619519&listName=nbdiscuss the
current work on projects prototype has been stopped.

Marking issue as CLOSED.