This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 30276 - Scan is performed even when suggestions view is closed
Summary: Scan is performed even when suggestions view is closed
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Hints & Annotations (show other bugs)
Version: 3.x
Hardware: PC All
: P3 blocker (vote)
Assignee: Torbjorn Norbye
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2003-01-22 16:35 UTC by David Simonek
Modified: 2004-01-14 13:05 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Simonek 2003-01-22 16:35:27 UTC
I think automatic scanning should be disabled when
suggestions view is not visible.
My motivation is that when I'm writing the code, I
often close suggestions view in hope to make
editor respond faster. It's natural that heavy
online parsing which is needed for suggestions
functionality will add some overhead.
Comment 1 Torbjorn Norbye 2003-01-22 16:55:09 UTC
Scanning -should- be disabled when the suggestions view is not visible
- there is a lot of code in there to ensure that, so if it's
continuing to scan when the view is not visible I've broken something.
I'll see if I can reproduce the problem.

I wanted precisely the behavior you're describing: you only expose the
suggestions view when you want to pay for the overhead of scanning.
Comment 2 David Simonek 2003-01-23 11:53:28 UTC
Hmm, I think I have more information - javadoc auto commenter seems to
be that bad guy who is still scanning while suggestions view is
closed. It could be more clear from bug 30308, which I'm able to
reproduce even when suggestions view is closed. Hope it helps...
Comment 3 Torbjorn Norbye 2003-01-23 22:44:54 UTC
I looked into it on the train this morning and found the problem. I
was adding a listener on the DataObject registry (to be notified of
file-saved). Then when the window is hidden I removed the listener.
However, I had added a weaklistener, so the removeListener call wasn't
sending in the same reference - therefore, the listener was not
removed after hiding the window.

Can you confirm that you were using scan-on-save, not scan-on-edit,
mode? (Since my problem is specific to save-scanning).

I have verified that when I hide the window and edit or save I don't
see any further scanning.  I will putback my fixes shortly.
Comment 4 _ pkuzel 2004-01-14 13:05:49 UTC
It was resolved in 3.6 time or earlier.