This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 30969 - DelegatingWatch doesn't get removed from Validator
Summary: DelegatingWatch doesn't get removed from Validator
Status: VERIFIED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Code (show other bugs)
Version: 3.x
Hardware: PC Windows ME/2000
: P1 blocker (vote)
Assignee: issues@debugger
URL:
Keywords: PERFORMANCE
Depends on: 31275
Blocks: 34160
  Show dependency tree
 
Reported: 2003-02-11 17:55 UTC by kyleyj
Modified: 2003-07-08 21:43 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description kyleyj 2003-02-11 17:55:59 UTC 
Whenever a watch is created, either by the 
ToolTipAnnotation or by creating a fixed watch, a 
DelegatingWatch is created.  However, the DelegatingWatch 
never gets removed from the Validator.  For instance, if 
you highlight a particular variable to display it's 
value 'n' times, that variable is validated 'n' times.  
Additionally, the Validator holds a reference to these 
DelegatingWatches even after the IDE has been shutdown.

This causes several problems: continuous adding of 
variables to validation; variables from another debugging 
session are being validated that aren't even valid for the 
source file; time and memory wasted.

I first found this while implementing my own debugger and 
thought that I was missing something.  However, debugging 
Java files has the same problem.

I'm running NB 3.4.1, JDK 1.4.1_01, Win2K.
Comment 1 Jan Jancura 2003-02-20 16:42:29 UTC 
I have found some memory lead in TreeTable - this is probably the
problem...
Comment 2 Jan Jancura 2003-02-20 18:05:40 UTC 
No, problem was in ToolTipAnnotation class.
fixed in the main trunk
Comment 3 dnoyeB 2003-02-21 14:48:11 UTC 
That is a nice catch.  I wonder what the implications will be? 
Perhaps related to those who have frustration with debugging speed?
Comment 4 kyleyj 2003-02-21 14:50:36 UTC 
I'm just glad that it was such an easy thing to find and 
fix.  I can only imagine the impacts on speed that have 
been seen as more and more watches are added to the 
validation.

Thanks.  It's working great for me now.
Comment 5 Jan Jancura 2003-02-21 16:27:16 UTC 
dnoyeB: I do not have performance data, but it should help.
Unfortunatelly there is one more memory-leak: 31275
And its worser. But good thing is that its identified and MUST be
fixed to nb3.5. So it should fix problem, that each new debuggins
session is slower and slower.
Comment 6 kyleyj 2003-07-08 21:43:07 UTC 
The changes in ToolTipAnnotation correctly fixed the 
validation of Watch variables.