This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 31639 - a11y: No accessible description for the `Select The Patch For Files In WEB-INF`
Summary: a11y: No accessible description for the `Select The Patch For Files In WEB-INF`
Status: VERIFIED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Diff (show other bugs)
Version: -S1S-
Hardware: All All
: P2 blocker (vote)
Assignee: Richard Gregor
URL:
Keywords: A11Y
Depends on:
Blocks:
 
Reported: 2003-03-04 08:48 UTC by Jason Rush
Modified: 2003-07-16 10:58 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Rush 2003-03-04 08:48:09 UTC
Description: 


Name: ssR10187			Date: 03/04/2003


  Product Version       = Sun ONE Studio 5, Standard Edition (Build 030228)
  IDE Versioning        = IDE/1 spec=3.38 impl=030228
  Operating System      = SunOS version 5.8 running on sparc
  Java; VM; Vendor      = 1.4.0; Java HotSpot(TM) Client VM 1.4.0-b92; Sun 
Microsystems Inc.

   To reproduce the bug:

1. Create Web Module in some mounted dir
2. Highlight the Web Module node
3. Bring up the context menu.
4. Select 'Tools/Apply Patch' from context menu

See results of Accessibility Tester:
===============================================
 Tested Window title : Select The Patch For Files In WEB-INF
===============================================

 No Accessible name :
   Class: javax.swing.plaf.metal.MetalFileChooserUI$5 {  |  } 


 No Accessible description :
   Class: javax.swing.JComboBox {  Files of Type: |  } 
   Class: javax.swing.JComboBox {  Look In: |  } 
   Class: javax.swing.JDialog {  Select The Patch For Files In WEB-INF |  } 
   Class: javax.swing.plaf.metal.MetalFileChooserUI$2 {  File Name: |  } 
   Class: javax.swing.plaf.metal.MetalFileChooserUI$5 {  |  } 

 Components with no LABEL_FOR pointing to it :
   Class: javax.swing.plaf.metal.MetalFileChooserUI$5 {  |  } 

 Components with no mnemonic :
   Class: javax.swing.JButton {  Home |  Home } 
   Class: javax.swing.JButton {  New Folder |  Create New Folder } 
   Class: javax.swing.JButton {  Patch |  Select the patch file to apply. } 
   Class: javax.swing.JButton {  Up |  Up One Level } 
   Class: javax.swing.JToggleButton {  Details |  Details } 
   Class: javax.swing.JToggleButton {  List |  List } 

======================================================================

A comment.
Comment 1 Jason Rush 2003-03-04 08:49:32 UTC
Transferred from BugTraq #4826839.
Comment 2 Petr Jiricka 2003-03-04 16:34:30 UTC
Could you please verify that this only happens for the WEB-
INF node, or does it happen for any node ?

I am assigning to the diff module, which owns this action.
Comment 3 Martin Entlicher 2003-03-04 21:09:12 UTC
IMHO this happens for any node. There's no reason to happen only for
WEB-INF node.
It's a bug in diff module.
Comment 4 Martin Entlicher 2003-03-05 09:48:04 UTC
Richard, can you look at this?
Comment 5 Richard Gregor 2003-03-05 17:42:27 UTC
Fixed. There is accessible description for chooser dialog.

Checking in src/org/netbeans/modules/diff/Bundle.properties;
/cvs/diff/src/org/netbeans/modules/diff/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.16; previous revision: 1.15
done
Checking in src/org/netbeans/modules/diff/PatchAction.java;
/cvs/diff/src/org/netbeans/modules/diff/PatchAction.java,v  <-- 
PatchAction.java
new revision: 1.9; previous revision: 1.8
Comment 6 Richard Gregor 2003-03-05 17:48:30 UTC
Also merged into release35 branch

Checking in src/org/netbeans/modules/diff/Bundle.properties;
/cvs/diff/src/org/netbeans/modules/diff/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.15.4.1; previous revision: 1.15
done
Checking in src/org/netbeans/modules/diff/PatchAction.java;
/cvs/diff/src/org/netbeans/modules/diff/PatchAction.java,v  <-- 
PatchAction.java
new revision: 1.8.2.1; previous revision: 1.8
done
Comment 7 Jiri Kovalsky 2003-07-15 15:42:24 UTC
Well, maybe I am wrong but shouldn't "Patch" button either be default
or have some mnemonics assigned ? Reopening in NetBeans 3.5.1 build
#200307092351.
Comment 8 Richard Gregor 2003-07-16 10:00:31 UTC
Problem is that there is valid mnemonic set for Patch button -
JFileChooser simply doesn't react on it. Patch button is set as
defualt - try to use enter on dialog. Problem is that it doesn't draw
thick line around default button - it is bad behavior coded inside
JFileChooser I assume - problem is in using JDialog not JOptionPane in
showDialog method.
Comment 9 Richard Gregor 2003-07-16 10:29:48 UTC
Signing as fixed - accessible description is there.
Comment 10 Jiri Kovalsky 2003-07-16 10:58:26 UTC
Okay, verified in Sun ONE Studio 5.0 Standard Edition build #030528.